Merge lp:~sinzui/launchpad/wax-and-wane into lp:launchpad
Proposed by
Curtis Hovey
Status: | Merged | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Merged at revision: | not available | ||||||||||||||||
Proposed branch: | lp:~sinzui/launchpad/wax-and-wane | ||||||||||||||||
Merge into: | lp:launchpad | ||||||||||||||||
Diff against target: |
296 lines (+110/-63) 8 files modified
lib/canonical/launchpad/icing/style-3-0.css (+3/-0) lib/lp/registry/browser/mailinglists.py (+13/-4) lib/lp/registry/browser/milestone.py (+1/-1) lib/lp/registry/browser/tests/mailinglist-message-views.txt (+74/-0) lib/lp/registry/browser/tests/milestone-views.txt (+15/-2) lib/lp/registry/browser/tests/test_views.py (+1/-0) lib/lp/registry/doc/message-holds.txt (+0/-52) lib/lp/registry/templates/milestone-index.pt (+3/-4) |
||||||||||||||||
To merge this branch: | bzr merge lp:~sinzui/launchpad/wax-and-wane | ||||||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+17141@code.launchpad.net |
To post a comment you must log in.
This is my branch to fix from simple nuisances in launchpad.
lp:~sinzui/launchpad/wax-and-wane /bugs.launchpad .net/bugs/ wax-and- wane message- views implementation: no one
Diff size: 206
Launchpad bug: https:/
Test command: ./bin/test -vv \
-t mailinglist-
-t milestone-views
Pre-
Target release: 10.01
Fix from simple nuisances in launchpad ------- ------- ------- ------- ------- ------- ------- ------- -----
-------
Bug #504024 [invalid list moderation markup breaks webkit] moderation. pt create ill-formed markup
The HeldMessageView and message-
that makes the message moderation page unusable in webkit browsers. I
have observed two issues:
1) The template uses `structure view/author`, but the author field is not
HTML. The angle brackets are not escaped, creating an unclosed tag.
2) The view's initialize() method is using `paragraphs. append( '\n<p>\ n')`
which creates an unclosed paragraph. (this markup was deprecated in 1994
and it invalid XHTML which the page claims to be).
Both of these errors can cause form submittal errors.
Bug #505919 [milestones assignees wrap poorly]
The assignee name wraps to the next line and it is difficult to see
understand that the number belongs to the next name.
Bug #505917 [Sort milestone bugs by status by default]
People working the bugs need to see status, then importance.
Rules
-----
Bug #504024 [invalid list moderation markup breaks webkit]
* Add a <p> before each added paragraph and change the markup added
afterwards to </p>
* Remove the `structure` command
Bug #505919 [milestones assignees wrap poorly]
* Add a CSS class to prevent the count and name from wrapping.
* ADDENDUM: white-space: nowrap does not work because the comma is
allowed to wrap. The pre value works if the markup is has no line breaks
Bug #505917 [Sort milestone bugs by status by default]
* Change the sort order in the view.
QA
--
Bug #504024 [invalid list moderation markup breaks webkit] /edge.launchpad .net/~launchpad -users/ +mailinglist- moderate
* Visit https:/
* Verify the From address shows the real address in the VIAGRA messages.
* Expand a real message (not an empty spam)
* Verify the paragraphs are shown as paragraphs.
Bug #505919 [milestones assignees wrap poorly] /edge.launchpad .net/launchpad- registry/ +milestone/ 10.01
* Visit https:/
* Verify assignee names do not wrap in activities portlet.
Bug #505917 [Sort milestone bugs by status by default] /edge.launchpad .net/launchpad- registry/ +milestone/ 10.01
* Visit https:/
* Verify that the bugs are listed from triaged, in progress, fix committed
to fix released.
Lint
----
Linting changed files: /launchpad/ icing/style- 3-0.css registry/ browser/ mailinglists. py registry/ browser/ milestone. py registry/ browser/ tests/mailingli st-message- views.txt registry/ browser/ tests/milestone -views. txt registry/ browser/ tests/test_ views.py registry/ templates/ milestone- index.pt
lib/canonical
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Test
----
* lib/lp/ registry/ browser/ tests/test_ views.py message- views.tx. ..
* Registered mailinglist-