Code review comment for lp:~sinzui/launchpad/prf-connection-0

Revision history for this message
Robert Collins (lifeless) wrote :

On Sat, Feb 12, 2011 at 10:29 AM, Curtis Hovey
<email address hidden> wrote:
> We do not want to log an error for user data: The issue of getting feedback is covered in bug 70524. It is out of scope for this issue.

Agreed; am glad there is a bug already. But we should log /what the
error was/ not just that there was an error. e.g

except (IOError, OSError), e:
   log("failure %s" % e)

(done minimally here)

« Back to merge proposal