Merge lp:~sil2100/otto/autopilot_add_setup_upstart_job into lp:otto/autopilot

[Łukasz Zemczak]

Add the otto-autopilot-setup.conf upstart job for configuring autopilot users correctly. It seems that python-autopilot prepares the autopilot group, but it only adds the currently logged in user (we don't have that). So, to fix permissions, we need to add ubuntu to autopilot automatically. Otherwise, /dev/uinput is inaccessible.

[Jean-Baptiste Lallement (jibel)]

Thanks for you work, I have a few comments though:
1. env DEBIAN_FRONTEND=noninteractive is useless because the job doesn't install any package, but it doesn't hurt.
2. There is no error handling around usermod call. Since this job will run on every boot it is possible that the user is already a member of this group and the job will fail. You should at least test for group membership.
3. The function "exit_job" doesn't exit, you can just remove that line

review: Needs Fixing

[Łukasz Zemczak (sil2100)]

Thanks! Fixing!

[lp:~sil2100/otto/autopilot_add_setup_upstart_job]

39. By Łukasz Zemczak on 2013-06-24

Remove unnecessary elements

40. By Łukasz Zemczak on 2013-06-24

Add a check for existence of autopilot and ubuntu

41. By Łukasz Zemczak on 2013-06-24

Final improvements (I hope)

[Francis Ginther (fginther)]

Looks like it should work.

review: Approve

[Jean-Baptiste Lallement (jibel)]

Thanks for this patch. Approved.

review: Approve

=== added file 'target-override/etc/init/otto-autopilot-setup.conf'
--- target-override/etc/init/otto-autopilot-setup.conf	1970-01-01 00:00:00 +0000
+++ target-override/etc/init/otto-autopilot-setup.conf	2013-06-24 16:48:31 +0000
@@ -0,0 +1,15 @@
+description "Setup evnivonment specific to the autopilot jobs for otto"
+author "Łukasz 'sil2100' Zemczak <[e-mail]>"
+
+start on (starting lightdm and stopped otto-setup)
+
+pre-start script
+    # Add the ubuntu user to the autopilot group, as only the autopilot group
+    # has the required permissions to access /dev/uinput
+
+    if getent group autopilot >/dev/null && getent passwd ubuntu >/dev/null; then
+        echo "Adding the ubuntu user to the autopilot group"
+        usermod -a -G autopilot ubuntu
+    fi
+
+end script