Otto

Code review comment for lp:~sil2100/otto/autopilot_add_setup_upstart_job

  1. autopilot_add_setup_upstart_job
  2. Merge into testsuite_autopilot-unity
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Thanks for you work, I have a few comments though:
1. env DEBIAN_FRONTEND=noninteractive is useless because the job doesn't install any package, but it doesn't hurt.
2. There is no error handling around usermod call. Since this job will run on every boot it is possible that the user is already a member of this group and the job will fail. You should at least test for group membership.
3. The function "exit_job" doesn't exit, you can just remove that line

review: Needs Fixing

« Back to merge proposal