Code review comment for lp:~sil2100/compiz/quickfix_1141079

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Heya,

Haven't had a chance to run the code yet, but I spotted something here:

97 + Window w = XCreateWindow (dpy, DefaultRootWindow (dpy),
98 + 0, 0, 100, 100, 0, CopyFromParent,
99 + InputOutput, CopyFromParent, 0,
100 + &attr);

You need to specify a changemask for attr, eg

unsigned int mask = CWOverrideRedirect;

97 + Window w = XCreateWindow (dpy, DefaultRootWindow (dpy),
98 + 0, 0, 100, 100, 0, CopyFromParent,
99 + InputOutput, CopyFromParent, mask,
100 + &attr);

« Back to merge proposal