lp:~sil2100/compiz/quickfix_1141079

Branch merges

Propose for merging

No branches dependent on this one.

Superseded for merging into lp:compiz/0.9.9

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2013-04-03

Daniel van Vugt: Needs Resubmitting on 2013-04-03

Sam Spilsbury: Approve on 2013-04-03

Łukasz Zemczak: Needs Information on 2013-03-29

Diff: 242 lines (+137/-22)

5 files modified

src/event.cpp (+21/-19)
tests/system/xorg-gtest/tests/compiz_xorg_gtest_configure_window.cpp (+99/-0)
tests/xorg-gtest/include/compiz-xorg-gtest.h (+2/-1)
tests/xorg-gtest/plugins/testhelper/src/testhelper.cpp (+1/-0)
tests/xorg-gtest/src/compiz-xorg-gtest.cpp (+14/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1141079: [regression-r3606] Compiz broken with QT menus/floating controls in 13.04

High

Fix Released

Link a bug report

Related blueprints

3642. By Łukasz Zemczak on 2013-04-02

As recommended by Sam, let's divide the one helper function into two smaller ones and create the tests using those helpers.

3641. By Łukasz Zemczak on 2013-04-02

Remove the '~test1' addition.

3640. By Łukasz Zemczak on 2013-04-02

To avoid too much code duplication, export the new test code into a helper method and use it to execute the 4 newly added tests.

3639. By Łukasz Zemczak on 2013-04-02

Thanks Sam for pointing this out! It seems we were missing a mask for the override_redirect attribute in XCreateWindow()!

3638. By Łukasz Zemczak on 2013-03-29

Some fixes to the added tests. Also, add another test related to the override bit.

3637. By Łukasz Zemczak on 2013-03-26

Still WIP, doing it in small chunks of code since I'm working on this in free time slices ;)

3636. By Łukasz Zemczak on 2013-03-21

Started work on the testing code for the introduced code. WIP!

3635. By Łukasz Zemczak on 2013-03-19

As mentioned by Sam, let's only set the additional attributes when XGetWindowAttributes doesn't fail.

3634. By Łukasz Zemczak on 2013-03-14

Remove the override_redirect xcreatewindow event assignment from revision 3606. This fixes the Qt menu regressions (LP: #1141079)

3633. By Sam Spilsbury on 2013-03-13

Don't set lastFrameExtents unless the window geometry actually changed - as
that variable only exists to track changes in the actual geometry of
the window and not the apparant frame extents.

Added tests to verify that behaviour.

(LP: #1138517). Fixes: https://bugs.launchpad.net/bugs/1138517.

Approved by PS Jenkins bot, Timo Jyrinki.