Code review comment for lp:~sil2100/compiz/quickfix_1141079

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

Hi Sam! Could you check the testing code?

Since I don't know if I'm doing anything wrong, but it seems the override_redirect attribute is not properly propagated with the XCreateWindow() call when using this branch. The CreateDestroyWindowOverrideRedirectTrue test I created fails, and when debugging in detail it seems that the CompWindow that reaches the TestHelperWindow ctor for the window I created (with the override_redirect attribute set) has the override_redirect flag reset to 0 again ;/ Not sure where that happens...
Do you have any clue what's wrong by any chance?

review: Needs Information

« Back to merge proposal