Merge lp:~sil2100/compiz-workarounds-plugin/initial_damage into lp:compiz-workarounds-plugin
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Daniel van Vugt | ||||
Approved revision: | 121 | ||||
Merged at revision: | 119 | ||||
Proposed branch: | lp:~sil2100/compiz-workarounds-plugin/initial_damage | ||||
Merge into: | lp:compiz-workarounds-plugin | ||||
Diff against target: |
69 lines (+23/-0) 3 files modified
src/workarounds.cpp (+14/-0) src/workarounds.h (+4/-0) workarounds.xml.in (+5/-0) |
||||
To merge this branch: | bzr merge lp:~sil2100/compiz-workarounds-plugin/initial_damage | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Approve | ||
Sam Spilsbury | Approve | ||
Review via email: mp+94232@code.launchpad.net |
Description of the change
= Problem description =
Sometimes, X returns strange XDamageNotifyEv
= The fix =
As a workaround, we prepare a damageRect() callback that forces a complete window redraw for initial damage handling (as advised by Sam, thanks!)
= Test coverage =
It is possible to check if the fix works by trying to reproduce the #931473 bug with the fix applied. Fast titlebar context menu invoking now always shows the menu fully redrawn.
In testing it seems to work fine. But I do have some concerns:
1. This workaround is not configurable. It's hard-coded.
2. I don't think we have found the root cause. It's only a workaround.
3. Because of #1, we may never notice or solve #2.