Code review comment for lp:~sil2100/appmenu-qt5/workaround_1306472_icontheme

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Looks fine (the signals trick is needed), builds fine and I can't spot any regressions in my usual test cases of Qt Creator and Transmission. Nice!

I'm unsure though how to the test the actual bug, but nothing seems wrong.

review: Approve

« Back to merge proposal