Merge lp:~sil2100/appmenu-qt5/workaround_1306472_icontheme into lp:appmenu-qt5
Proposed by
Łukasz Zemczak
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Timo Jyrinki | ||||
Approved revision: | 17 | ||||
Merged at revision: | 17 | ||||
Proposed branch: | lp:~sil2100/appmenu-qt5/workaround_1306472_icontheme | ||||
Merge into: | lp:appmenu-qt5 | ||||
Diff against target: |
96 lines (+43/-1) 3 files modified
debian/control (+1/-0) src/appmenuplatformmenubar.cpp (+41/-0) src/src.pro (+1/-1) |
||||
To merge this branch: | bzr merge lp:~sil2100/appmenu-qt5/workaround_1306472_icontheme | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Timo Jyrinki | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Indicator Applet Developers | Pending | ||
Review via email:
|
Commit message
When working with a Gnome/GTK theme, do the same thing as the gtk2 platformtheme plugin does - fetch the SystemIconThemeName (and its fallback) from settings in the system
Description of the change
When working with a Gnome/GTK theme, do the same thing as the gtk2 platformtheme plugin does - fetch the SystemIconThemeName (and its fallback) from settings in the system
This is not a perfect solution, as appmenu should not bother with themeing and be only responsible for exporting the menu, delegating everything else to Qt itself.
To post a comment you must log in.
PASSED: Continuous integration, rev:17 jenkins. qa.ubuntu. com/job/ appmenu- qt5-ci/ 3/ jenkins. qa.ubuntu. com/job/ appmenu- qt5-trusty- amd64-ci/ 3 jenkins. qa.ubuntu. com/job/ appmenu- qt5-trusty- armhf-ci/ 3 jenkins. qa.ubuntu. com/job/ appmenu- qt5-trusty- armhf-ci/ 3/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/appmenu- qt5-ci/ 3/rebuild
http://