1
=== modified file 'providers/plainbox-provider-certification-client/units/client-cert-14-04-3.pxu'
2
--- providers/plainbox-provider-certification-client/units/client-cert-14-04-3.pxu	2015-05-20 06:58:13 +0000
3
+++ providers/plainbox-provider-certification-client/units/client-cert-14-04-3.pxu	2015-05-20 10:15:25 +0000
4
@@ -418,6 +418,8 @@
5
418
    sysctl_attachment
418
    sysctl_attachment
6
419
    sysfs_attachment
419
    sysfs_attachment
7
420
    udev_attachment
420
    udev_attachment
8
421
    recovery_info_attachment
9
422
    dell_bto_xml_attachment
10
421
    lsmod_attachment
423
    lsmod_attachment
11
422
    dkms_info_attachment
424
    dkms_info_attachment
12
423
    acpi_sleep_attachment
425
    acpi_sleep_attachment
13
424
426
14
=== modified file 'providers/plainbox-provider-certification-client/units/client-cert-14-04.pxu'
15
--- providers/plainbox-provider-certification-client/units/client-cert-14-04.pxu	2015-05-18 10:56:27 +0000
16
+++ providers/plainbox-provider-certification-client/units/client-cert-14-04.pxu	2015-05-20 10:15:25 +0000
17
@@ -402,6 +402,8 @@
18
402
    sysctl_attachment
402
    sysctl_attachment
19
403
    sysfs_attachment
403
    sysfs_attachment
20
404
    udev_attachment
404
    udev_attachment
21
405
    recovery_info_attachment
22
406
    dell_bto_xml_attachment
23
405
    lsmod_attachment
407
    lsmod_attachment
24
406
    acpi_sleep_attachment
408
    acpi_sleep_attachment
25
407
    info/hdparm
409
    info/hdparm
26
408
410
27
=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-cert-regression.whitelist'
28
--- providers/plainbox-provider-certification-client/whitelists/client-cert-regression.whitelist	2015-05-14 19:32:33 +0000
29
+++ providers/plainbox-provider-certification-client/whitelists/client-cert-regression.whitelist	2015-05-20 10:15:25 +0000
30
@@ -129,6 +129,8 @@
31
129
sysctl_attachment
129
sysctl_attachment
32
130
sysfs_attachment
130
sysfs_attachment
33
131
udev_attachment
131
udev_attachment
34
132
recovery_info_attachment
35
133
dell_bto_xml_attachment
36
132
lsmod_attachment
134
lsmod_attachment
37
133
dkms_info_attachment
135
dkms_info_attachment
38
134
acpi_sleep_attachment
136
acpi_sleep_attachment
39
135
137
40
=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist'
41
--- providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist	2015-05-18 10:56:27 +0000
42
+++ providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist	2015-05-20 10:15:25 +0000
43
@@ -419,6 +419,8 @@
44
419
sysctl_attachment
419
sysctl_attachment
45
420
sysfs_attachment
420
sysfs_attachment
46
421
udev_attachment
421
udev_attachment
47
422
recovery_info_attachment
48
423
dell_bto_xml_attachment
49
422
lsmod_attachment
424
lsmod_attachment
50
423
dkms_info_attachment
425
dkms_info_attachment
51
424
acpi_sleep_attachment
426
acpi_sleep_attachment
52
425
427
53
=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist'
54
--- providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist	2015-05-18 06:25:15 +0000
55
+++ providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist	2015-05-20 10:15:25 +0000
56
@@ -359,6 +359,8 @@
57
359
sysctl_attachment
359
sysctl_attachment
58
360
sysfs_attachment
360
sysfs_attachment
59
361
udev_attachment
361
udev_attachment
60
362
recovery_info_attachment
61
363
dell_bto_xml_attachment
62
362
lsmod_attachment
364
lsmod_attachment
63
363
dkms_info_attachment
365
dkms_info_attachment
64
364
acpi_sleep_attachment
366
acpi_sleep_attachment
65
365
367
66
=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist'
67
--- providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist	2015-05-18 06:25:15 +0000
68
+++ providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist	2015-05-20 10:15:25 +0000
69
@@ -359,6 +359,8 @@
70
359
sysctl_attachment
359
sysctl_attachment
71
360
sysfs_attachment
360
sysfs_attachment
72
361
udev_attachment
361
udev_attachment
73
362
recovery_info_attachment
74
363
dell_bto_xml_attachment
75
362
lsmod_attachment
364
lsmod_attachment
76
363
dkms_info_attachment
365
dkms_info_attachment
77
364
acpi_sleep_attachment
366
acpi_sleep_attachment
78
365
367
79
=== added file 'providers/plainbox-provider-checkbox/bin/recovery_info'
80
--- providers/plainbox-provider-checkbox/bin/recovery_info	1970-01-01 00:00:00 +0000
81
+++ providers/plainbox-provider-checkbox/bin/recovery_info	2015-05-20 10:15:25 +0000
82
@@ -0,0 +1,389 @@
83
1
#!/usr/bin/env python3
84
2
# Copyright 2015 Canonical Ltd.
85
3
# Written by:
86
4
#   Shawn Wang <shawn.wang@canonical.com>
87
5
#
88
6
# This program is free software: you can redistribute it and/or modify
89
7
# it under the terms of the GNU General Public License version 3,
90
8
# as published by the Free Software Foundation.
91
9
#
92
10
# This program is distributed in the hope that it will be useful,
93
11
# but WITHOUT ANY WARRANTY; without even the implied warranty of
94
12
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
95
13
# GNU General Public License for more details.
96
14
#
97
15
# You should have received a copy of the GNU General Public License
98
16
# along with this program.  If not, see <http://www.gnu.org/licenses/>.
99
17
100
18
"""Show the recovery partition information for the preinstalled OS."""
101
19
102
20
import os
103
21
import subprocess
104
22
import sys
105
23
import tempfile
106
24
import unittest
107
25
import xml.dom.minidom as minidom
108
26
109
27
from guacamole import Command
110
28
111
29
try:
112
30
    from unittest import mock
113
31
except ImportError:
114
32
    from plainbox.vendor import mock
115
33
116
34
RECOVERY_LABELS = {"HP_TOOLS": "HP",
117
35
                   "PQSERVICE": "UBUNTU",
118
36
                   "BACKUP": "TEST",
119
37
                   "INSTALL": "DELL",
120
38
                   "OS": "DELL",
121
39
                   "RECOVERY": "DELL"}
122
40
123
41
RECOVERY_PACKAGES = ["dell-recovery", "ubuntu-recovery", "zip"]
124
42
125
43
126
44
class MountedPartition(object):
127
45
128
46
    """
129
47
    Mount Manager to mount partition on tempdir.
130
48
131
49
    e.g.
132
50
    with MountedPartition("/dev/sda1") as tmp:
133
51
        print("This is the mount point: {}".format(tmp))
134
52
        do_stuff()
135
53
    """
136
54
137
55
    def __init__(self, part):
138
56
        """
139
57
        Prepare the mntdir point.
140
58
141
59
        :param part: string of the partition device file, like /dev/sda2
142
60
        """
143
61
        self.part = part
144
62
        self.mntdir = tempfile.mkdtemp()
145
63
146
64
    def __enter__(self):
147
65
        """
148
66
        __enter__ method for python's with statement.
149
67
150
68
        Mount the partition device to the mntdir.
151
69
        """
152
70
        cmd = ["mount", self.part, self.mntdir]
153
71
        subprocess.check_output(cmd, universal_newlines=True)
154
72
        return self.mntdir
155
73
156
74
    def __exit__(self, type, value, traceback):
157
75
        """
158
76
        __exit__ method for python's with statement.
159
77
160
78
        Unmount and remove the mntdir.
161
79
        """
162
80
        subprocess.check_output(["umount", self.mntdir],
163
81
                                universal_newlines=True)
164
82
        os.rmdir(self.mntdir)
165
83
166
84
167
85
class MountedPartitionTests(unittest.TestCase):
168
86
169
87
    """Unittest of MountedPartition."""
170
88
171
89
    @mock.patch('subprocess.check_output')
172
90
    def test_with_of_MountedPartition(self, mock_subprocess_check_output):
173
91
        """Test mount point."""
174
92
        test_dir = ""
175
93
        with MountedPartition("/dev/test") as tmp:
176
94
            test_dir = tmp
177
95
            self.assertTrue(os.path.exists(test_dir))
178
96
            mock_subprocess_check_output.assert_has_calls(
179
97
                [mock.call(['mount', '/dev/test', test_dir],
180
98
                           universal_newlines=True)])
181
99
        self.assertFalse(os.path.exists(test_dir))
182
100
        mock_subprocess_check_output.assert_has_calls(
183
101
            [mock.call(['umount', test_dir],
184
102
                       universal_newlines=True)])
185
103
186
104
187
105
class RecoveryVersion(Command):
188
106
189
107
    """
190
108
    subcommand of RecoveryInfo.
191
109
192
110
    print out the version information.
193
111
194
112
    image_version: xxx
195
113
    bto_version: REV_xxx.iso (dell only)
196
114
    """
197
115
198
116
    def invoked(self, ctx):
199
117
        """
200
118
        Guacamole method called when the command is invoked.
201
119
202
120
        /etc/buildstamp is a image information file,
203
121
        it created by the oem image builder.
204
122
205
123
        oilpalm Fri, 20 Jun 2014 04:02:07 +0000
206
124
        somerville-trusty-amd64-20140620-0
207
125
208
126
        If /etc/buildstamp exist, print out the second line (image iso name).
209
127
210
128
        For Dell-recovery partition, /etc/buildstamp shows base image info.
211
129
        If recovery_partition/bto.xml,
212
130
        print out the bto_version (read from xml file).
213
131
        """
214
132
        if os.path.isfile("/etc/buildstamp"):
215
133
            with open('/etc/buildstamp', 'rt', encoding='UTF-8') as stream:
216
134
                data = stream.readlines()
217
135
                print("image_version: {}".format(data[1].strip()))
218
136
219
137
        with MountedPartition(ctx.recovery_partition) as mntdir:
220
138
            fname = "{}/bto.xml".format(mntdir)
221
139
            if os.path.isfile(fname):
222
140
                o = minidom.parse("{}/bto.xml".format(mntdir))
223
141
                bto_version = o.getElementsByTagName("iso")[0].firstChild.data
224
142
                print("bto_version: {}".format(bto_version))
225
143
226
144
227
145
class RecoveryFile(Command):
228
146
229
147
    """
230
148
    subcommand of RecoveryInfo.
231
149
232
150
    print out the file in recovery partition.
233
151
    """
234
152
235
153
    def register_arguments(self, parser):
236
154
        """
237
155
        Guacamole method used by the argparse ingredient.
238
156
239
157
        :param parser:
240
158
            Argument parser (from :mod:`argparse`) specific to this command.
241
159
        """
242
160
        parser.add_argument('file', help='File name of print out the content')
243
161
244
162
    def invoked(self, ctx):
245
163
        """
246
164
        Guacamole method used by the command ingredient.
247
165
248
166
        :param ctx:
249
167
            The guacamole context object. Context provides access to all
250
168
            features of guacamole. The argparse ingredient adds the ``args``
251
169
            attribute to it. That attribute contains the result of parsing
252
170
            command line arguments.
253
171
        :returns:
254
172
            The return code of the command. Guacamole translates ``None`` to a
255
173
            successful exit status (return code zero).
256
174
        """
257
175
        if ctx.args.file is None:
258
176
            return 1
259
177
        with MountedPartition(ctx.recovery_partition) as mntdir:
260
178
            fname = "{}/{}".format(mntdir, ctx.args.file)
261
179
            try:
262
180
                with open(fname, 'rt', encoding='UTF-8') as f:
263
181
                    print(f.read())
264
182
            except Exception as e:
265
183
                sys.stderr.write(
266
184
                    "File({}) is not found, {}\n".format(ctx.args.file, e.msg))
267
185
                return 1
268
186
269
187
270
188
class RecoveryCheckType(Command):
271
189
272
190
    """
273
191
    subcommand of RecoveryInfo.
274
192
275
193
    Check the recovery type if not matched return 1
276
194
    """
277
195
278
196
    def register_arguments(self, parser):
279
197
        """
280
198
        Guacamole method used by the argparse ingredient.
281
199
282
200
        :param parser:
283
201
            Argument parser (from :mod:`argparse`) specific to this command.
284
202
        """
285
203
        parser.add_argument('type',
286
204
                            help="""\
287
205
Check current recovery type, like DELL.
288
206
If current recovery type is DELL, return value is 0.
289
207
If current recovery type is not DELL, return value is 1.
290
208
""")
291
209
292
210
    def invoked(self, ctx):
293
211
        """
294
212
        Guacamole method used by the command ingredient.
295
213
296
214
        :param ctx:
297
215
            The guacamole context object. Context provides access to all
298
216
            features of guacamole. The argparse ingredient adds the ``args``
299
217
            attribute to it. That attribute contains the result of parsing
300
218
            command line arguments.
301
219
        :returns:
302
220
            The return code of the command. Guacamole translates ``None`` to a
303
221
            successful exit status (return code zero).
304
222
        """
305
223
        if ctx.recovery_type != ctx.args.type.upper():
306
224
            sys.stderr.write(
307
225
                "{} and {}".format(ctx.recovery_type,
308
226
                                   ctx.args.type.upper()))
309
227
            sys.stderr.write(ctx.args.type.upper())
310
228
            return 1
311
229
312
230
313
231
class RecoveryInfo(Command):
314
232
315
233
    """
316
234
    RecoveryInfo command.
317
235
318
236
    If system is not a preinstalled OS, the command return 1.
319
237
    """
320
238
321
239
    sub_commands = (
322
240
        ('version', RecoveryVersion),
323
241
        ('file', RecoveryFile),
324
242
        ('checktype', RecoveryCheckType),
325
243
    )
326
244
327
245
    @staticmethod
328
246
    def get_recovery_package():
329
247
        """
330
248
        Test with RECOVERY_PACKAGES.
331
249
332
250
        to check recovery application is installed or not
333
251
334
252
        :return:
335
253
            string of package_version or None
336
254
        """
337
255
        for pkg in RECOVERY_PACKAGES:
338
256
            output = subprocess.check_output(["apt-cache", "policy", pkg],
339
257
                                             universal_newlines=True)
340
258
            for line in output.split("\n"):
341
259
                if line.startswith("  Installed:"):
342
260
                    ver = line.split(": ")[1]
343
261
                    return "{}_{}".format(pkg, ver.strip())
344
262
        return None
345
263
346
264
    @staticmethod
347
265
    def get_recovery_partition():
348
266
        """
349
267
        Look for the recovery partition.
350
268
351
269
         1. Check recovery package is installed or not.
352
270
         2. Use blkid to get partition tables
353
271
         3. Recovery partition type is ntfs or vfat
354
272
         4. RECOVERY_LABELS to see if any partition match
355
273
356
274
        :return:
357
275
            (recovery_type, recovery_partition) or None
358
276
        """
359
277
        if RecoveryInfo.get_recovery_package() is None:
360
278
            return None
361
279
362
280
        output = subprocess.check_output(["blkid"], universal_newlines=True)
363
281
        data = output.strip()
364
282
365
283
        if data == "":
366
284
            raise OSError("Please run by root. "
367
285
                          "Although blkid can runs without root, "
368
286
                          "it only works after root runs blkid.")
369
287
370
288
        for section in data.split("\n"):
371
289
            blk = {}
372
290
            blk['dev'], line = section.split(': ')
373
291
            line = line.strip() + " "
374
292
375
293
            for part in line.split('" '):
376
294
                item = part.split("=\"")
377
295
                if item[0] == 'LABEL':
378
296
                    blk['label'] = item[1].upper()
379
297
                if item[0] == 'TYPE':
380
298
                    blk['fs'] = item[1]
381
299
            if 'label' not in blk:
382
300
                continue
383
301
384
302
            if not (blk['fs'] == "vfat" or
385
303
                    blk['fs'] == "ntfs"):
386
304
                continue
387
305
            for label in RECOVERY_LABELS:
388
306
                if blk['label'] == label:
389
307
                    return (RECOVERY_LABELS[label], blk['dev'])
390
308
        return None
391
309
392
310
    def invoked(self, ctx):
393
311
        """
394
312
        Guacamole method used by the command ingredient.
395
313
396
314
        :param ctx:
397
315
            The guacamole context object. Context provides access to all
398
316
            features of guacamole. The argparse ingredient adds the ``args``
399
317
            attribute to it. That attribute contains the result of parsing
400
318
            command line arguments.
401
319
        :returns:
402
320
            The return code of the command. Guacamole translates ``None`` to a
403
321
            successful exit status (return code zero).
404
322
        """
405
323
        partition = RecoveryInfo.get_recovery_partition()
406
324
407
325
        if partition is None:
408
326
            sys.stderr.write("Recovery partition not found\n")
409
327
            return 1
410
328
411
329
        (recovery_type, recovery_partition) = partition
412
330
        ctx.recovery_partition = recovery_partition
413
331
        ctx.recovery_type = recovery_type
414
332
415
333
416
334
class RecoveryInfoGuacamoleCommendTests(unittest.TestCase):
417
335
418
336
    """Unittest of RecoveryInfo."""
419
337
420
338
    @mock.patch('subprocess.check_output')
421
339
    def testRecoveryInfo_get_recovery_package(self,
422
340
                                              mock_subprocess_check_output):
423
341
        """Unittest of RecoveryInfo.get_recovery_package()."""
424
342
        mock_subprocess_check_output.return_value = """\
425
343
dell-recovery:
426
344
  Installed: 1.11
427
345
  Candidate: 1.11
428
346
  Version table:
429
347
     1.11
430
348
        500 https://archive/cesg-mirror/ test/public amd64 Packages
431
349
"""
432
350
        self.assertEqual(RecoveryInfo.get_recovery_package(),
433
351
                         "dell-recovery_1.11")
434
352
435
353
    @mock.patch('__main__.RecoveryInfo.get_recovery_package')
436
354
    @mock.patch('subprocess.check_output')
437
355
    def testRecoveryInfo_get_recovery_partition(self,
438
356
                                                mock_subprocess_check_output,
439
357
                                                mock_get_recovery_package):
440
358
        """Unittest of RecoveryInfo.get_recovery_partition()."""
441
359
        mock_get_recovery_package.return_value = "dell-recovery_1.11"
442
360
        mock_subprocess_check_output.return_value = """\
443
361
/dev/sda1: LABEL="Test" UUID="xxxxx" TYPE="vfat" PARTUUID="00070b83-01"
444
362
/dev/sda2: UUID="xxxxx" TYPE="vfat" PARTUUID="00070b83-02"
445
363
/dev/sda3: LABEL="Recovery" UUID="xxxxx" TYPE="vfat" PARTUUID="00070b83-06"
446
364
"""
447
365
        self.assertEqual(RecoveryInfo.get_recovery_partition(),
448
366
                         ("DELL", "/dev/sda3"))
449
367
450
368
    @mock.patch('__main__.RecoveryInfo.get_recovery_package')
451
369
    @mock.patch('__main__.RecoveryInfo.get_recovery_partition')
452
370
    def testRecoveryInfo_guacamole(self,
453
371
                                   mock_get_recovery_partition,
454
372
                                   mock_get_recovery_package):
455
373
        """Unittest of command with argv."""
456
374
        mock_get_recovery_partition.return_value = ("DELL", "/dev/sda3")
457
375
        mock_get_recovery_package.return_value = "dell-recovery_1.11"
458
376
459
377
        self.assertEqual(RecoveryInfo().main(argv=None, exit=False), 0)
460
378
        self.assertEqual(
461
379
            RecoveryInfo().main(argv=["checktype", "HP"], exit=False), 1)
462
380
        self.assertEqual(
463
381
            RecoveryInfo().main(argv=["checktype", "DELL"], exit=False), 0)
464
382
465
383
466
384
if __name__ == '__main__':
467
385
    if '--test' in sys.argv:
468
386
        sys.argv.remove('--test')
469
387
        unittest.main()
470
388
    else:
471
389
        RecoveryInfo().main()
472
0
390
473
=== modified file 'providers/plainbox-provider-checkbox/jobs/info.txt.in'
474
--- providers/plainbox-provider-checkbox/jobs/info.txt.in	2015-05-14 19:32:33 +0000
475
+++ providers/plainbox-provider-checkbox/jobs/info.txt.in	2015-05-20 10:15:25 +0000
476
@@ -276,6 +276,54 @@
477
276
_summary: Attach /etc/buildstamp
276
_summary: Attach /etc/buildstamp
478
277
command: [ -s /etc/buildstamp ] && cat /etc/buildstamp
277
command: [ -s /etc/buildstamp ] && cat /etc/buildstamp
479
278
278
480
279
plugin: shell
481
280
id: info/detect_recovery
482
281
requires: package.name == 'dell-recovery' or package.name == 'ubuntu-recovery'
483
282
user: root
484
283
estimated_duration: 0.2
485
284
_summary: Check existence of recovery partition
486
285
_description: Check existence of recovery partition
487
286
command: recovery_info --check-recovery-partition
488
287
489
288
plugin: shell
490
289
id: info/detect_dell_recovery
491
290
depends: info/detect_recovery
492
291
requires: package.name == 'dell-recovery'
493
292
user: root
494
293
estimated_duration: 0.2
495
294
_summary: Check the recovery type is dell or not
496
295
_description: Check the recovery type is dell or not
497
296
command: recovery_info --check-recovery-type DELL
498
297
499
298
plugin: attachment
500
299
id: recovery_info_attachment
501
300
depends: info/detect_recovery
502
301
requires: package.name == 'dell-recovery' or package.name == 'ubuntu-recovery'
503
302
user: root
504
303
estimated_duration: 0.2
505
304
_summary: Attach the recovery partition versions
506
305
_description:
507
306
 Attach the recovery partition version
508
307
 image_version is the preinstalled OS image version
509
308
 bto_version is only for dell_recovery
510
309
 Example:
511
310
 image_version: somerville-trusty-amd64-20140620-0
512
311
 bto_version: A00_dell-bto-trusty-houston-15-A11-iso-20141203-0.iso
513
312
command: recovery_info --show-version
514
313
515
314
plugin: attachment
516
315
id: dell_bto_xml_attachment
517
316
depends: info/detect_dell_recovery
518
317
requires: package.name == 'dell-recovery'
519
318
estimated_duration: 0.5
520
319
_summary: Attach the bto.xml in Dell recovery partition
521
320
_description:
522
321
 bto.xml is basically a Fish manifest
523
322
 The information include:
524
323
  - fish packages
525
324
  - dell recovery stage 2 boot log
526
325
command: recovery_info --readfile bto.xml
527
326
528
279
plugin: attachment
327
plugin: attachment
529
280
id: info/kvm_output
328
id: info/kvm_output
530
281
estimated_duration: 0.1
329
estimated_duration: 0.1
531
282
330
532
=== modified file 'providers/plainbox-provider-checkbox/whitelists/autotesting.whitelist'
533
--- providers/plainbox-provider-checkbox/whitelists/autotesting.whitelist	2015-05-14 19:32:33 +0000
534
+++ providers/plainbox-provider-checkbox/whitelists/autotesting.whitelist	2015-05-20 10:15:25 +0000
535
@@ -25,6 +25,8 @@
536
25
sysctl_attachment
25
sysctl_attachment
537
26
sysfs_attachment
26
sysfs_attachment
538
27
udev_attachment
27
udev_attachment
539
28
recovery_info_attachment
540
29
dell_bto_xml_attachment
541
28
lsmod_attachment
30
lsmod_attachment
542
29
dkms_info_attachment
31
dkms_info_attachment
543
30
#Automated Test-verification Jobs
32
#Automated Test-verification Jobs
544
31
33
545
=== modified file 'providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist'
546
--- providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist	2015-05-14 19:32:33 +0000
547
+++ providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist	2015-05-20 10:15:25 +0000
548
@@ -16,6 +16,8 @@
549
16
dmi_attachment
16
dmi_attachment
550
17
dmidecode_attachment
17
dmidecode_attachment
551
18
kernel_cmdline_attachment
18
kernel_cmdline_attachment
552
19
recovery_info_attachment
553
20
dell_bto_xml_attachment
554
19
lsmod_attachment
21
lsmod_attachment
555
20
dkms_info_attachment
22
dkms_info_attachment
556
21
lspci_attachment
23
lspci_attachment
Reviewer	Date Requested	Status
Zygmunt Krynicki (community)	2015-04-29	Approve on 2015-05-20
Sylvain Pineau (community)		Needs Fixing on 2015-05-19
Review via email: mp+257761@code.launchpad.net