Code review comment for lp:~shawn111/checkbox/image_info

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

More inline comments below. Please ping me again after addressing all of the comments.

One more thing, to make it explicit: please define the version of Ubuntu that this script aims to support. This is important for things like udisks API and transition processes. Define your requirements and we'll see what to do about that.

Lastly. I'm somewhat tempted to move all of the DELL-specific stuff into a DELL provider though this can be done later.

« Back to merge proposal