On Tue, May 13, 2014 at 1:22 PM, Robert Bruce Park <
<email address hidden>> wrote:
> Review: Needs Fixing
>
> Changelog should be urgency=low. I have seen citrain have unexpected
> results from urgency=medium.
>
As Colin mentions, it's the tool's default
>
> Also, please `wrap-and-sort -a -t` to get the Dependencies: field wrapped
> properly, and add the "if you don't have have commit access..." comment as
> per https://wiki.ubuntu.com/DailyRelease/InlinePackaging
>
The thing I don't like about adding the comment is that wrap-and-sort wipes
it and I like to run it often (I clearly missed it this time :-P)
>
> debian/copyright has a copy&paste error, it references nuntium (twice),
> which is an unrelated project. Please change that to udm.
>
On Tue, May 13, 2014 at 1:22 PM, Robert Bruce Park <
<email address hidden>> wrote:
> Review: Needs Fixing
>
> Changelog should be urgency=low. I have seen citrain have unexpected
> results from urgency=medium.
>
As Colin mentions, it's the tool's default
> /wiki.ubuntu. com/DailyReleas e/InlinePackagi ng
> Also, please `wrap-and-sort -a -t` to get the Dependencies: field wrapped
> properly, and add the "if you don't have have commit access..." comment as
> per https:/
>
The thing I don't like about adding the comment is that wrap-and-sort wipes
it and I like to run it often (I clearly missed it this time :-P)
>
> debian/copyright has a copy&paste error, it references nuntium (twice),
> which is an unrelated project. Please change that to udm.
>
Nice catch
> Otherwise it mostly looks good.
>
Thanks