udm

Merge lp:~sergiusens/udm/packaging into lp:udm

Proposed by Sergio Schvezov
Status: Merged
Approved by: Robert Bruce Park
Approved revision: no longer in the source branch.
Merged at revision: 2
Proposed branch: lp:~sergiusens/udm/packaging
Merge into: lp:udm
Diff against target: 91 lines (+60/-0)
6 files modified
.bzr-builddeb/default.conf (+2/-0)
debian/changelog (+5/-0)
debian/compat (+1/-0)
debian/control (+22/-0)
debian/copyright (+22/-0)
debian/rules (+8/-0)
To merge this branch: bzr merge lp:~sergiusens/udm/packaging
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Approve
Review via email: mp+219387@code.launchpad.net

Commit message

Initial packaging

To post a comment you must log in.
Revision history for this message
Robert Bruce Park (robru) wrote :

Changelog should be urgency=low. I have seen citrain have unexpected results from urgency=medium.

Also, please `wrap-and-sort -a -t` to get the Dependencies: field wrapped properly, and add the "if you don't have have commit access..." comment as per https://wiki.ubuntu.com/DailyRelease/InlinePackaging

debian/copyright has a copy&paste error, it references nuntium (twice), which is an unrelated project. Please change that to udm.

Otherwise it mostly looks good.

review: Needs Fixing
Revision history for this message
Colin Watson (cjwatson) wrote :

On Tue, May 13, 2014 at 04:22:32PM -0000, Robert Bruce Park wrote:
> Changelog should be urgency=low. I have seen citrain have unexpected results from urgency=medium.

We should track that down and fix it if it's still the case, since (a)
urgency=medium is meant to be entirely valid and (b) it's the default
used by dch nowadays.

FWIW I haven't seen any problems with urgency=medium in click.

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

On Tue, May 13, 2014 at 1:22 PM, Robert Bruce Park <
<email address hidden>> wrote:

> Review: Needs Fixing
>
> Changelog should be urgency=low. I have seen citrain have unexpected
> results from urgency=medium.
>

As Colin mentions, it's the tool's default

>
> Also, please `wrap-and-sort -a -t` to get the Dependencies: field wrapped
> properly, and add the "if you don't have have commit access..." comment as
> per https://wiki.ubuntu.com/DailyRelease/InlinePackaging
>

The thing I don't like about adding the comment is that wrap-and-sort wipes
it and I like to run it often (I clearly missed it this time :-P)

>
> debian/copyright has a copy&paste error, it references nuntium (twice),
> which is an unrelated project. Please change that to udm.
>

Nice catch

> Otherwise it mostly looks good.
>

Thanks

Revision history for this message
Robert Bruce Park (robru) wrote :

True, we should track that down. Maybe set it back to urgency=medium and just see what happens. I don't remember quite how it explodes, but I think it'll try to cram an extra nonsensical entry into debian/changelog for you. If you want a smooth ride for now, leave it as low, but if you wanna be a guinea pig, set it back to medium and we'll see what happens.

Revision history for this message
Robert Bruce Park (robru) :
review: Approve
lp:~sergiusens/udm/packaging updated
2. By Sergio Schvezov

Initial packaging

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory '.bzr-builddeb'
2=== added file '.bzr-builddeb/default.conf'
3--- .bzr-builddeb/default.conf 1970-01-01 00:00:00 +0000
4+++ .bzr-builddeb/default.conf 2014-05-13 19:51:42 +0000
5@@ -0,0 +1,2 @@
6+[BUILDDEB]
7+split = True
8
9=== added directory 'debian'
10=== added file 'debian/changelog'
11--- debian/changelog 1970-01-01 00:00:00 +0000
12+++ debian/changelog 2014-05-13 19:51:42 +0000
13@@ -0,0 +1,5 @@
14+golang-udm (0.1-0ubuntu1) UNRELEASED; urgency=low
15+
16+ * Initial packaging.
17+
18+ -- Sergio Schvezov <sergio.schvezov@canonical.com> Thu, 03 Apr 2014 15:01:24 -0300
19
20=== added file 'debian/compat'
21--- debian/compat 1970-01-01 00:00:00 +0000
22+++ debian/compat 2014-05-13 19:51:42 +0000
23@@ -0,0 +1,1 @@
24+9
25
26=== added file 'debian/control'
27--- debian/control 1970-01-01 00:00:00 +0000
28+++ debian/control 2014-05-13 19:51:42 +0000
29@@ -0,0 +1,22 @@
30+Source: golang-udm
31+Section: devel
32+Priority: optional
33+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
34+Build-Depends: debhelper (>= 9),
35+ dh-golang,
36+ golang-go,
37+ golang-go-dbus-dev,
38+Standards-Version: 3.9.5
39+Homepage: https://launchpad.net/udm
40+Vcs-Browser: http://bazaar.launchpad.net/~phablet-team/udm/trunk/files
41+# if you don't have have commit access to this branch but would like to upload
42+# directly to Ubuntu, don't worry: your changes will be merged back into the
43+# upstream branch
44+Vcs-Bzr: lp:udm
45+
46+Package: golang-udm-dev
47+Architecture: all
48+Depends: ${misc:Depends},
49+Description: Go bindings for the Ubuntu Download Manager
50+ After importing this package you will be able to use the Ubuntu Download
51+ Manager from golang directly.
52
53=== added file 'debian/copyright'
54--- debian/copyright 1970-01-01 00:00:00 +0000
55+++ debian/copyright 2014-05-13 19:51:42 +0000
56@@ -0,0 +1,22 @@
57+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
58+Upstream-Name: udm
59+Source: https://launchpad.net/udm
60+
61+Files: *
62+Copyright: Copyright (C) 2014 Canonical, Ltd.
63+License: GPL-3
64+ This program is free software: you can redistribute it and/or modify it
65+ under the terms of the the GNU General Public License version 3, as
66+ published by the Free Software Foundation.
67+ .
68+ This program is distributed in the hope that it will be useful, but
69+ WITHOUT ANY WARRANTY; without even the implied warranties of
70+ MERCHANTABILITY, SATISFACTORY QUALITY or FITNESS FOR A PARTICULAR
71+ PURPOSE. See the applicable version of the GNU Lesser General Public
72+ License for more details.
73+ .
74+ You should have received a copy of the GNU General Public License
75+ along with this program. If not, see <http://www.gnu.org/licenses/>.
76+ .
77+ On Debian systems, the complete text of the GNU General Public License
78+ can be found in `/usr/share/common-licenses/GPL-3'
79
80=== added file 'debian/rules'
81--- debian/rules 1970-01-01 00:00:00 +0000
82+++ debian/rules 2014-05-13 19:51:42 +0000
83@@ -0,0 +1,8 @@
84+#!/usr/bin/make -f
85+# -*- makefile -*-
86+
87+export DH_OPTIONS
88+export DH_GOPKG := launchpad.net/udm
89+
90+%:
91+ dh $@ --buildsystem=golang --with=golang --fail-missing

Subscribers

People subscribed via source and target branches