Merge lp:~sergiusens/snapcraft/build-packages into lp:~snappy-dev/snapcraft/core

Proposed by Sergio Schvezov
Status: Merged
Approved by: Michael Vogt
Approved revision: 179
Merged at revision: 180
Proposed branch: lp:~sergiusens/snapcraft/build-packages
Merge into: lp:~snappy-dev/snapcraft/core
Diff against target: 94 lines (+10/-9)
8 files modified
examples/godd/snapcraft.yaml (+2/-1)
plugins/ant-project.yaml (+1/-1)
plugins/autotools-project.yaml (+1/-1)
plugins/cmake-project.yaml (+1/-1)
plugins/go.yaml (+1/-1)
plugins/make-project.yaml (+1/-1)
plugins/maven-project.yaml (+1/-1)
snapcraft/yaml.py (+2/-2)
To merge this branch: bzr merge lp:~sergiusens/snapcraft/build-packages
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Ted Gould Pending
Review via email: mp+271669@code.launchpad.net

This proposal supersedes a proposal from 2015-09-18.

Commit message

build-packages instead of build-tools to follow the spec

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/godd/snapcraft.yaml'
2--- examples/godd/snapcraft.yaml 2015-09-17 10:23:15 +0000
3+++ examples/godd/snapcraft.yaml 2015-09-18 14:56:19 +0000
4@@ -11,4 +11,5 @@
5 godd:
6 type: go-project
7 source: git://github.com/mvo5/godd
8-build-tools: [libgudev-1.0-dev]
9+build-packages:
10+ - libgudev-1.0-dev
11
12=== modified file 'plugins/ant-project.yaml'
13--- plugins/ant-project.yaml 2015-09-15 09:49:19 +0000
14+++ plugins/ant-project.yaml 2015-09-18 14:56:19 +0000
15@@ -10,5 +10,5 @@
16 stage-packages:
17 snap:
18 stage:
19-build-tools:
20+build-packages:
21 - ant
22
23=== modified file 'plugins/autotools-project.yaml'
24--- plugins/autotools-project.yaml 2015-09-08 18:06:03 +0000
25+++ plugins/autotools-project.yaml 2015-09-18 14:56:19 +0000
26@@ -1,5 +1,5 @@
27 module: autotools_project
28-build-tools: [autoconf, automake, autopoint]
29+build-packages: [autoconf, automake, autopoint]
30 options:
31 source:
32 required: true
33
34=== modified file 'plugins/cmake-project.yaml'
35--- plugins/cmake-project.yaml 2015-09-08 18:06:03 +0000
36+++ plugins/cmake-project.yaml 2015-09-18 14:56:19 +0000
37@@ -1,5 +1,5 @@
38 module: cmake_project
39-build-tools: [cmake]
40+build-packages: [cmake]
41 options:
42 source:
43 required: true
44
45=== modified file 'plugins/go.yaml'
46--- plugins/go.yaml 2015-08-14 20:04:30 +0000
47+++ plugins/go.yaml 2015-09-18 14:56:19 +0000
48@@ -1,2 +1,2 @@
49-build-tools:
50+build-packages:
51 - golang-go
52
53=== modified file 'plugins/make-project.yaml'
54--- plugins/make-project.yaml 2015-09-08 18:06:03 +0000
55+++ plugins/make-project.yaml 2015-09-18 14:56:19 +0000
56@@ -1,5 +1,5 @@
57 module: make_project
58-build-tools: [make]
59+build-packages: [make]
60 options:
61 source:
62 required: true
63
64=== modified file 'plugins/maven-project.yaml'
65--- plugins/maven-project.yaml 2015-09-08 18:06:03 +0000
66+++ plugins/maven-project.yaml 2015-09-18 14:56:19 +0000
67@@ -1,5 +1,5 @@
68 module: maven_project
69-build-tools:
70+build-packages:
71 - maven
72 requires:
73 - jdk
74
75=== modified file 'snapcraft/yaml.py'
76--- snapcraft/yaml.py 2015-09-18 03:23:38 +0000
77+++ snapcraft/yaml.py 2015-09-18 14:56:19 +0000
78@@ -75,7 +75,7 @@
79 self.data = _snapcraft_yaml_load()
80 _validate_snapcraft_yaml(self.data)
81
82- self.build_tools = self.data.get('build-tools', [])
83+ self.build_tools = self.data.get('build-packages', [])
84
85 for part_name in self.data.get("parts", []):
86 properties = self.data["parts"][part_name] or {}
87@@ -160,7 +160,7 @@
88 def load_plugin(self, part_name, plugin_name, properties, load_code=True):
89 part = snapcraft.plugin.load_plugin(part_name, plugin_name, properties, load_code=load_code)
90
91- self.build_tools += part.config.get('build-tools', [])
92+ self.build_tools += part.config.get('build-packages', [])
93 self.all_parts.append(part)
94 return part
95

Subscribers

People subscribed via source and target branches