Merge lp:~sergiusens/snapcraft/build-packages into lp:~ted/snapcraft/python-pip

Proposed by Sergio Schvezov
Status: Superseded
Proposed branch: lp:~sergiusens/snapcraft/build-packages
Merge into: lp:~ted/snapcraft/python-pip
Diff against target: 93 lines (+10/-8)
8 files modified
examples/godd/snapcraft.yaml (+2/-0)
plugins/ant-project.yaml (+1/-1)
plugins/autotools-project.yaml (+1/-1)
plugins/cmake-project.yaml (+1/-1)
plugins/go.yaml (+1/-1)
plugins/make-project.yaml (+1/-1)
plugins/maven-project.yaml (+1/-1)
snapcraft/yaml.py (+2/-2)
To merge this branch: bzr merge lp:~sergiusens/snapcraft/build-packages
Reviewer Review Type Date Requested Status
Ted Gould Pending
Review via email: mp+271668@code.launchpad.net

This proposal has been superseded by a proposal from 2015-09-18.

Commit message

build-packages instead of build-tools to follow the spec

To post a comment you must log in.

Unmerged revisions

179. By Sergio Schvezov

build-packages instead of build-tools to follow the spec

178. By Ted Gould

Add in support for PIP requirements.txt files in the python plugins. by ted approved by sergiusens

177. By Daniel Holbach

add libgudev-1.0-dev as build-tools for godd example by dholbach approved by sergiusens

176. By Sergio Schvezov

setup.py using pypy to setup a config integration test by sergiusens approved by elopio

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/godd/snapcraft.yaml'
2--- examples/godd/snapcraft.yaml 2015-09-08 11:48:30 +0000
3+++ examples/godd/snapcraft.yaml 2015-09-18 14:55:41 +0000
4@@ -11,3 +11,5 @@
5 godd:
6 type: go-project
7 source: git://github.com/mvo5/godd
8+build-packages:
9+ - libgudev-1.0-dev
10
11=== modified file 'plugins/ant-project.yaml'
12--- plugins/ant-project.yaml 2015-09-15 09:49:19 +0000
13+++ plugins/ant-project.yaml 2015-09-18 14:55:41 +0000
14@@ -10,5 +10,5 @@
15 stage-packages:
16 snap:
17 stage:
18-build-tools:
19+build-packages:
20 - ant
21
22=== modified file 'plugins/autotools-project.yaml'
23--- plugins/autotools-project.yaml 2015-09-08 18:06:03 +0000
24+++ plugins/autotools-project.yaml 2015-09-18 14:55:41 +0000
25@@ -1,5 +1,5 @@
26 module: autotools_project
27-build-tools: [autoconf, automake, autopoint]
28+build-packages: [autoconf, automake, autopoint]
29 options:
30 source:
31 required: true
32
33=== modified file 'plugins/cmake-project.yaml'
34--- plugins/cmake-project.yaml 2015-09-08 18:06:03 +0000
35+++ plugins/cmake-project.yaml 2015-09-18 14:55:41 +0000
36@@ -1,5 +1,5 @@
37 module: cmake_project
38-build-tools: [cmake]
39+build-packages: [cmake]
40 options:
41 source:
42 required: true
43
44=== modified file 'plugins/go.yaml'
45--- plugins/go.yaml 2015-08-14 20:04:30 +0000
46+++ plugins/go.yaml 2015-09-18 14:55:41 +0000
47@@ -1,2 +1,2 @@
48-build-tools:
49+build-packages:
50 - golang-go
51
52=== modified file 'plugins/make-project.yaml'
53--- plugins/make-project.yaml 2015-09-08 18:06:03 +0000
54+++ plugins/make-project.yaml 2015-09-18 14:55:41 +0000
55@@ -1,5 +1,5 @@
56 module: make_project
57-build-tools: [make]
58+build-packages: [make]
59 options:
60 source:
61 required: true
62
63=== modified file 'plugins/maven-project.yaml'
64--- plugins/maven-project.yaml 2015-09-08 18:06:03 +0000
65+++ plugins/maven-project.yaml 2015-09-18 14:55:41 +0000
66@@ -1,5 +1,5 @@
67 module: maven_project
68-build-tools:
69+build-packages:
70 - maven
71 requires:
72 - jdk
73
74=== modified file 'snapcraft/yaml.py'
75--- snapcraft/yaml.py 2015-09-18 03:23:38 +0000
76+++ snapcraft/yaml.py 2015-09-18 14:55:41 +0000
77@@ -75,7 +75,7 @@
78 self.data = _snapcraft_yaml_load()
79 _validate_snapcraft_yaml(self.data)
80
81- self.build_tools = self.data.get('build-tools', [])
82+ self.build_tools = self.data.get('build-packages', [])
83
84 for part_name in self.data.get("parts", []):
85 properties = self.data["parts"][part_name] or {}
86@@ -160,7 +160,7 @@
87 def load_plugin(self, part_name, plugin_name, properties, load_code=True):
88 part = snapcraft.plugin.load_plugin(part_name, plugin_name, properties, load_code=load_code)
89
90- self.build_tools += part.config.get('build-tools', [])
91+ self.build_tools += part.config.get('build-packages', [])
92 self.all_parts.append(part)
93 return part
94

Subscribers

People subscribed via source and target branches

to all changes: