Phablet Tools

Code review comment for lp:~sergiusens/phablet-tools/1233800

  1. 1233800
  2. Merge into trunk
Revision history for this message
Andy Doan (doanac) wrote :

Seems okay. I'd almost prefer ditching the time.sleep stuff and use an option like "--dryrun" that just dumps that info and exits. If you prefer keeping it this way, there's a small punctuation nitpick:

Please add a space after the period here:
+ print('\n\nFlashing revision %s from channel %s.'
ie:
  print('\n\nFlashing revision %s from channel %s. '

review: Approve

« Back to merge proposal