Merge lp:~sergiusens/phablet-tools/1233800 into lp:phablet-tools

[Sergio Schvezov]

Provide some information of revision/version and channel used when flashing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:211
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/222/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-amd64-ci/165
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-armhf-ci/165
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-i386-ci/166

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/phablet-tools-ci/222/rebuild

review: Approve (continuous-integration)

[Andy Doan (doanac)]

Seems okay. I'd almost prefer ditching the time.sleep stuff and use an option like "--dryrun" that just dumps that info and exits. If you prefer keeping it this way, there's a small punctuation nitpick:

Please add a space after the period here:
+ print('\n\nFlashing revision %s from channel %s.'
ie:
  print('\n\nFlashing revision %s from channel %s. '

review: Approve

[Sergio Schvezov (sergiusens)]

On Mon, Oct 21, 2013 at 11:50 PM, Andy Doan <email address hidden>wrote:

> Review: Approve
>
> Seems okay. I'd almost prefer ditching the time.sleep stuff and use an
> option like "--dryrun" that just dumps that info and exits. If you prefer
> keeping it this way, there's a small punctuation nitpick:
>

The sleep is from the bug report :-) If popey agrees, I can then modify.

Please add a space after the period here:
> + print('\n\nFlashing revision %s from channel %s.'
> ie:
> print('\n\nFlashing revision %s from channel %s. '
>

Good catch, I really don't like having those non spaced EOSs :-)

[Alan Pope 🍺🐧🐱 🦄 (popey)]

I agree, a dry run or simulate would probably be more consistent with our other tools than a "run and then ctrl+c if it's wrong" which I originally suggested, even though I'd prefer that personally, it seems wrong.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:212
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/227/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-amd64-ci/170
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-armhf-ci/170
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-i386-ci/171

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/phablet-tools-ci/227/rebuild

review: Approve (continuous-integration)

[lp:~sergiusens/phablet-tools/1233800]

211. By Sergio Schvezov on 2013-10-28

Logging channel and version

[Sergio Schvezov (sergiusens)]

I'm just logging now with no message about cancelling and would rather add the dryrun as a different bug report as it involves adding the option to everything

review: Needs Resubmitting

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Dryrun option added as bug 1245512

[Alan Pope 🍺🐧🐱 🦄 (popey)]

review: Approve

=== modified file 'phabletutils/environment.py'
--- phabletutils/environment.py	2013-10-15 19:30:43 +0000
+++ phabletutils/environment.py	2013-10-28 14:16:01 +0000
@@ -163,6 +163,8 @@
         download_dir_part = os.path.join(download_dir_part, base_uri)
     download_dir = downloads.get_full_path(download_dir_part)
 
+    log.info('Flashing revision %s from channel %s' %
+             (json['version'], args.channel))
     files, command_part = ubuntuimage.get_files(download_dir, uri, json)
     return projects.UbuntuTouchSystem(
         file_list=files,