Code review comment for ~sergiodj/ubuntu/+source/nfs-utils:bug1918141-service-file-adjustment

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Changelog:
- [✓] old content and logical tag match as expected
- [✓] changelog entry correct version and targeted codename
- [✓] changelog entries correct
- [✓] update-maintainer has been run

New Delta:
- [✓] new patches are good or match what was proposed upstream
- [✓] new patches correctly included in debian/patches/series?

I've found the related 53f31f060e94fb0318418485fc2ab7149ab27f18, maybe with that as first patch in the series it would all apply as-is instead of being a backport.

- [?] new patches have correct DEP3 metadata

It misses Bug-Ubuntu: in the dep-3 headers, if you'd like to add that for completeness that would be nice. Not too much of an issue since the file name and changelog have the references.

Build/Test:
- [✓] build is ok
- [✓] verified PPA package installs/uninstalls
- [✓] autopkgtest against the PPA package passes

No case is a blocker, but I'd want you to reconsider my comments - hence "need info"

review: Needs Information

« Back to merge proposal