Merge ~sergiodj/ubuntu/+source/nfs-utils:bug1918141-service-file-adjustment into ubuntu/+source/nfs-utils:ubuntu/hirsute-devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Sergio Durigan Junior | ||||
Approved revision: | 933b5e24073286377ddbcd865a694f1bb8c97f5b | ||||
Merged at revision: | 7b867e3d88b56257af5b12d4a8996ee9e5c5d1bd | ||||
Proposed branch: | ~sergiodj/ubuntu/+source/nfs-utils:bug1918141-service-file-adjustment | ||||
Merge into: | ubuntu/+source/nfs-utils:ubuntu/hirsute-devel | ||||
Diff against target: |
198 lines (+170/-0) 4 files modified
debian/changelog (+11/-0) debian/patches/lp1918141-use-network-online-target-01.patch (+82/-0) debian/patches/lp1918141-use-network-online-target-02.patch (+75/-0) debian/patches/series (+2/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Needs Information | ||
Canonical Server | Pending | ||
Review via email: mp+399688@code.launchpad.net |
Description of the change
This is a fix for bug 1918141 on hirsute.
The issue here is that nfs-utils' systemd service file doesn't properly depend on network-
The bug is a bit tricky to reproduce, but you can find instructions in the bug comments (more especifically, comment #5).
nfs-utils is really old on Ubuntu/Debian, but I was able to backport the proper fixes from the upstream git. You will notice that, although the changes made to the service file are simple, I opted to keep them separated in two patches. This is done to reflect the fact that the change was made in two upstream commits.
You can find a PPA with the proposed fix here:
https:/
autopkgtest is still happy:
autopkgtest [19:30:09]: @@@@@@@
local-server-client PASS
Changelog:
- [✓] old content and logical tag match as expected
- [✓] changelog entry correct version and targeted codename
- [✓] changelog entries correct
- [✓] update-maintainer has been run
New Delta: patches/ series?
- [✓] new patches are good or match what was proposed upstream
- [✓] new patches correctly included in debian/
I've found the related 53f31f060e94fb0 318418485fc2ab7 149ab27f18, maybe with that as first patch in the series it would all apply as-is instead of being a backport.
- [?] new patches have correct DEP3 metadata
It misses Bug-Ubuntu: in the dep-3 headers, if you'd like to add that for completeness that would be nice. Not too much of an issue since the file name and changelog have the references.
Build/Test:
- [✓] build is ok
- [✓] verified PPA package installs/uninstalls
- [✓] autopkgtest against the PPA package passes
No case is a blocker, but I'd want you to reconsider my comments - hence "need info"