Code review comment for lp:~sergei.glushchenko/percona-xtrabackup/xb2.0-bug483827

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Sergei,

As discussed on IRC, --defaults-group does not necessarily have to be the first option, so docs should be corrected.

And, while you are at it would be good to correct built-in help for --defaults-group in innobackupex.

Help text for other options either have units or some description of possible values after the '=' sign, e.g.:

--ibbackup=IBBACKUP-BINARY
--remote-host=HOSTNAME

So the text for --defaults-group should be something like "--defaults-group=GROUP-NAME" rather thatn "--defaults-group=mysqld".

review: Needs Fixing

« Back to merge proposal