Merge lp:~sergei.glushchenko/percona-xtrabackup/xb2.0-bug483827 into lp:percona-xtrabackup/2.0
Proposed by
Sergei Glushchenko
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Alexey Kopytov | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 431 | ||||
Proposed branch: | lp:~sergei.glushchenko/percona-xtrabackup/xb2.0-bug483827 | ||||
Merge into: | lp:percona-xtrabackup/2.0 | ||||
Prerequisite: | lp:~sergei.glushchenko/percona-xtrabackup/xb2.0-bug996493 | ||||
Diff against target: |
325 lines (+108/-19) 6 files modified
doc/source/how-tos.rst (+1/-0) doc/source/innobackupex/innobackupex_option_reference.rst (+4/-0) doc/source/xtrabackup_bin/xbk_option_reference.rst (+4/-0) innobackupex (+34/-16) src/xtrabackup.c (+20/-3) test/t/bug483827.sh (+45/-0) |
||||
To merge this branch: | bzr merge lp:~sergei.glushchenko/percona-xtrabackup/xb2.0-bug483827 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov (community) | Approve | ||
Review via email: mp+106348@code.launchpad.net |
This proposal supersedes a proposal from 2012-03-29.
Description of the change
Bug #483827. Support for mysqld_multi.
Fix based on work of Daniël van Eeden (lp:~dveeden/percona-xtrabackup/lp483827)
--section option added to innobackupex, specifying which section of my.cnf to handle.
--mysqld-section option added to xtrabackup for the same purpose.
Tescase does not run mysqld_multi, it just tests correctness of --section option.
http://
To post a comment you must log in.
Sergei,
- sections in my.cnf are called groups in MySQL documentation. So defaults- group, rather than --section and --mysqld-section
let's be consistent and call them groups as well, and name the
options (both the innobackupex and the xtrabackup one)
--
- it looks like get_option is always passed the same value as its mysqld_ section (or whatever it will be defaults_ group) internally.
second argument, so I wonder if it really needs that argument, or
rather just use $option_
renamed to, i.e. $option_
- s/laod/load/ args/restore_ args/. Though you don't really need that
- s/accetps/accepts/
- s/rstore_
function, as tests are executed in a separate shell process, so
modifications to variables have no effect on other tests anyway.
- I know that code in main() that scan options for "--mysqld-section"
was copy-pasted, but please format it according to InnoDB
style. Because currently it's a terrible mix of all possible
formatting styles.
- in the same code, I don't think strstr() is necessary, because you
already have the pointer to '=' (or terminating zero) in optend.