- string values for most options in --print-param are enclosed in
double quotes. It only matters when path or file names contain
spaces.
> I added quotes
- MP and revision comments refer to a --remote-host test, but I don't
see it in the code (would also be rather tricky to test in the test
suite). I thought it was a typo for --rsync, but the rsync test is
also present in the 2.1 MP as it should be.
> Indeed, I mixed many things in one. And also forgot to add test for incremental backup.
- 5.6 version checks are different in test case. I suggest to use
"${MYSQL_VERSION:0:3}" != "5.6", the other one looks a bit
unreliable
> I modified version check to be comparison with "5.6"
- please rebase it on current trunks. my.cnf is handled differently
after recent merges, and the way it is done in these tests will
conflict. You can now specify MYSQLD_EXTRA_MY_CNF_OPTS and it will
be used by both server (no need for extra start_server arguments)
and innobackupex/xtrabackup
Alexei,
- string values for most options in --print-param are enclosed in
double quotes. It only matters when path or file names contain
spaces.
> I added quotes
- MP and revision comments refer to a --remote-host test, but I don't
see it in the code (would also be rather tricky to test in the test
suite). I thought it was a typo for --rsync, but the rsync test is
also present in the 2.1 MP as it should be.
> Indeed, I mixed many things in one. And also forgot to add test for incremental backup.
- 5.6 version checks are different in test case. I suggest to use MYSQL_VERSION: 0:3}" != "5.6", the other one looks a bit
"${
unreliable
> I modified version check to be comparison with "5.6"
- please rebase it on current trunks. my.cnf is handled differently EXTRA_MY_ CNF_OPTS and it will xtrabackup
after recent merges, and the way it is done in these tests will
conflict. You can now specify MYSQLD_
be used by both server (no need for extra start_server arguments)
and innobackupex/
> done.