Merge lp:~sergei.glushchenko/percona-xtrabackup/buffer_pool_dump into lp:percona-xtrabackup/2.0
Status: | Merged |
---|---|
Approved by: | Alexey Kopytov |
Approved revision: | no longer in the source branch. |
Merged at revision: | 546 |
Proposed branch: | lp:~sergei.glushchenko/percona-xtrabackup/buffer_pool_dump |
Merge into: | lp:percona-xtrabackup/2.0 |
Diff against target: |
291 lines (+194/-19) 5 files modified
innobackupex (+28/-19) src/xtrabackup.cc (+11/-0) test/t/ib_buffer_pool.sh (+57/-0) test/t/ib_buffer_pool_dump_incremental.sh (+58/-0) test/t/ib_buffer_pool_rsync.sh (+40/-0) |
To merge this branch: | bzr merge lp:~sergei.glushchenko/percona-xtrabackup/buffer_pool_dump |
Related bugs: | |
Related blueprints: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov (community) | Approve | ||
Review via email: mp+160825@code.launchpad.net |
Description of the change
Support for buffer pool dump MySQL 5.6
- MySQL 5.6 adds an ability to dump the buffer pool into file for it to be
possible to load it into memory at startup or on demand. The location of
buffer pool file is set by global variable innodb_
and is relative to MySQL data directory.
- The patch adds an ability to take a backup of buffer pool dump. It has been
made exactly the same way as XtraDB LRU dump is backed up.
- Two tests have been added for this feature. One takes regular backup and
after takes streaming backup. Another one takes backup with --remote-host
option. Second test has not been ported to 2.1 because --remote-host
option is not supported in 2.1.
- Also test for these features to work correctly with incremental backups
is implemented.
http://
Sergei,
- string values for most options in --print-param are enclosed in MYSQL_VERSION: 0:3}" != "5.6", the other one looks a bit EXTRA_MY_ CNF_OPTS and it will xtrabackup
double quotes. It only matters when path or file names contain
spaces.
- MP and revision comments refer to a --remote-host test, but I don't
see it in the code (would also be rather tricky to test in the test
suite). I thought it was a typo for --rsync, but the rsync test is
also present in the 2.1 MP as it should be.
- 5.6 version checks are different in test case. I suggest to use
"${
unreliable
- please rebase it on current trunks. my.cnf is handled differently
after recent merges, and the way it is done in these tests will
conflict. You can now specify MYSQLD_
be used by both server (no need for extra start_server arguments)
and innobackupex/