Code review comment for lp:~segphault/gwibber/secure-password-storage

Revision history for this message
Dominic Evans (oldmanuk) wrote :

Have been using this for a couple of days now as my main gwibber instance, without issue. Looks good to me.

My only tentative query would be your current choice of key description values referencing the gconf entry:

'Gwibber preference for /apps/gwibber/accounts/as90dua0s9ud0a9sud90ausd/password'

Why not something more human-readable, e.g., use the same text as displayed in the accounts menu:

'Microblogging account password for oldmanuk (Twitter)'
'Microblogging account password for oldmanuk (Identi.ca)'

etc.

Approve the merge though.

review: Approve

« Back to merge proposal