Merge lp:~segphault/gwibber/secure-password-storage into lp:gwibber/1.2

[Ryan Paul]

[Ryan Paul (segphault)]

I have finished implementing support for storing passwords in the GNOME keyring. This branch needs a lot of heavy testing. Please test and let me know if you encounter problems.

It should automatically use regular plaintext gconf storage as a fallback if the GNOME keyring isn't available. It will automatically move password values for a particular account to the GNOME keyring the first time that you open the properties dialog for that account.

After the password has been moved to the GNOME keyring, you should see :KEYRING:x as the value for that attribute in gconf, where "x" is an ID number associated with the keyring value. You can use the Seahorse utility to view the passwords that are stored in the keyring.

[lp:~segphault/gwibber/secure-password-storage]

239. By Ryan Paul on 2009-02-14

Include the GConf key name in the GNOME keyring item description

[Dominic Evans (oldmanuk)]

Have been using this for a couple of days now as my main gwibber instance, without issue. Looks good to me.

My only tentative query would be your current choice of key description values referencing the gconf entry:

'Gwibber preference for /apps/gwibber/accounts/as90dua0s9ud0a9sud90ausd/password'

Why not something more human-readable, e.g., use the same text as displayed in the accounts menu:

'Microblogging account password for oldmanuk (Twitter)'
'Microblogging account password for oldmanuk (Identi.ca)'

etc.

Approve the merge though.

review: Approve