Code review comment for lp:~seb128/thunderbird/default-profile-fix

Revision history for this message
Olivier Tilloy (osomon) wrote :

Thanks for the patch Séb.

This won't work in all cases though: for newly created profiles it will, but for profiles that were created before version 67 (see https://support.mozilla.org/gl/questions/1264072), they will still use the old naming convention, and therefore the presence and value of a "Default" key needs to be checked.

For reference this is what my profiles.ini looks like (where the profile being used by default is "fxbpdn4q.default"):

osomon@bribon:~$ cat .thunderbird/profiles.ini
[Install109C8E86A96C2F86]
Default=wa14rqag.default-beta
Locked=1

[Profile1]
Name=default-beta
IsRelative=1
Path=wa14rqag.default-beta

[Profile0]
Name=default
IsRelative=1
Path=fxbpdn4q.default
Default=1

[General]
StartWithLastProfile=1
Version=2

[InstallABD9122D5734A109]
Default=0t0vcddd.default-release
Locked=1

[InstallFDC34C9F024745EB]
Default=fxbpdn4q.default

[Profile2]
Name=default-release
IsRelative=1
Path=0t0vcddd.default-release

review: Needs Fixing

« Back to merge proposal