Merge lp:~seb128/thunderbird/default-profile-fix into lp:~mozillateam/thunderbird/thunderbird.groovy

[Sebastien Bacher]

[Olivier Tilloy (osomon)]

Thanks for the patch Séb.

This won't work in all cases though: for newly created profiles it will, but for profiles that were created before version 67 (see https://support.mozilla.org/gl/questions/1264072), they will still use the old naming convention, and therefore the presence and value of a "Default" key needs to be checked.

For reference this is what my profiles.ini looks like (where the profile being used by default is "fxbpdn4q.default"):

osomon@bribon:~$ cat .thunderbird/profiles.ini
[Install109C8E86A96C2F86]
Default=wa14rqag.default-beta
Locked=1

[Profile1]
Name=default-beta
IsRelative=1
Path=wa14rqag.default-beta

[Profile0]
Name=default
IsRelative=1
Path=fxbpdn4q.default
Default=1

[General]
StartWithLastProfile=1
Version=2

[InstallABD9122D5734A109]
Default=0t0vcddd.default-release
Locked=1

[InstallFDC34C9F024745EB]
Default=fxbpdn4q.default

[Profile2]
Name=default-release
IsRelative=1
Path=0t0vcddd.default-release

review: Needs Fixing

[Sebastien Bacher (seb128)]

The Default key isn't enough, on a profile created by 78 there is a profile with Default=1 set which isn't the one used, default-release is the active one

[Olivier Tilloy (osomon)]

Yes, so we need a different code path for thunderbird >= 78, and for thunderbird < 78.
I'll take a stab at it.

[Olivier Tilloy (osomon)]

I was wrong, this kind of profiles.ini with various profiles by default is already present with thunderbird 68.x.

Unmerged revisions

576. By Sebastien Bacher on 2020-10-28

source_thunderbird.py: correctly detect the default profile

=== modified file 'debian/apport/source_thunderbird.py.in'
--- debian/apport/source_thunderbird.py.in	2019-08-23 13:17:13 +0000
+++ debian/apport/source_thunderbird.py.in	2020-10-28 19:41:41 +0000
@@ -1247,7 +1247,7 @@
             if not parser.has_option(section, "Path"): continue
             path = parser.get(section, "Path")
             name = parser.get(section, "Name")
-            is_default = True if parser.has_option(section, "Default") and parser.getint(section, "Default") == 1 else False
+            is_default = True if 'default-release' in name else False
             self.profiles.append(Profile(section, name, os.path.join(profile_folder, path), is_default, appini))
 
         # No "Default" entry when there is one profile