Code review comment for lp:~seb128/indicator-application/dont-werror-on-deprecations

Revision history for this message
Sebastien Bacher (seb128) wrote :

Note that the current version fails to build with GTK 3.10, we might as well want to clean the deprecations (or not if we consider the component deprecated in unity8)

"indicator-application.c:477:2: error: 'gtk_widget_get_style' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkstyle.h:672): Use 'gtk_widget_get_style_context' instead [-Werror=deprecated-declarations]
  GtkStyle * style = gtk_widget_get_style(GTK_WIDGET(app->entry.label));
  ^
cc1: all warnings being treated as errors"

In any case the -Wno-error=deprecated-declarations makes sense since we agreed to not stop build on those

« Back to merge proposal