Merge lp:~seb128/indicator-application/dont-werror-on-deprecations into lp:indicator-application/14.04

[Sebastien Bacher]

don't error out on deprecated declarations

don't error out on deprecated declarations

[Sebastien Bacher (seb128)]

Note that the current version fails to build with GTK 3.10, we might as well want to clean the deprecations (or not if we consider the component deprecated in unity8)

"indicator-application.c:477:2: error: 'gtk_widget_get_style' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkstyle.h:672): Use 'gtk_widget_get_style_context' instead [-Werror=deprecated-declarations]
  GtkStyle * style = gtk_widget_get_style(GTK_WIDGET(app->entry.label));
  ^
cc1: all warnings being treated as errors"

In any case the -Wno-error=deprecated-declarations makes sense since we agreed to not stop build on those

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:244
http://jenkins.qa.ubuntu.com/job/indicator-application-ci/12/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-application-trusty-amd64-ci/4/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-application-trusty-armhf-ci/4/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-application-ci/12/rebuild

review: Needs Fixing (continuous-integration)

[Lars Karlitski (larsu)]

Thanks Seb!

review: Approve

[lp:~seb128/indicator-application/dont-werror-on-deprecations]

245. By Sebastien Bacher on 2014-01-17

include new lcov version

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:245
http://jenkins.qa.ubuntu.com/job/indicator-application-ci/13/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-application-trusty-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-application-trusty-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/indicator-application-trusty-armhf-ci/5/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-application-ci/13/rebuild

review: Approve (continuous-integration)

=== modified file 'm4/gcov.m4'
--- m4/gcov.m4	2012-03-27 21:08:10 +0000
+++ m4/gcov.m4	2014-01-17 10:59:49 +0000
@@ -30,7 +30,7 @@
     AC_MSG_ERROR([ccache must be disabled when --enable-gcov option is used. You can disable ccache by setting environment variable CCACHE_DISABLE=1.])
   fi
 
-  lcov_version_list="1.6 1.7 1.8 1.9"
+  lcov_version_list="1.6 1.7 1.8 1.9 1.10"
   AC_CHECK_PROG(LCOV, lcov, lcov)
   AC_CHECK_PROG(GENHTML, genhtml, genhtml)
 

=== modified file 'src/Makefile.am'
--- src/Makefile.am	2012-12-18 19:08:50 +0000
+++ src/Makefile.am	2014-01-17 10:59:49 +0000
@@ -21,7 +21,7 @@
 	-Wl,-Bsymbolic-functions \
 	-Wl,-z,defs \
 	-Wl,--as-needed \
-	-Werror \
+	-Werror -Wno-error=deprecated-declarations \
 	-DG_LOG_DOMAIN=\"Indicator-Application\"
 libapplication_la_LIBADD = $(INDICATOR_LIBS) 
 libapplication_la_LDFLAGS = $(COVERAGE_LDFLAGS) \
@@ -55,7 +55,7 @@
 	$(APPINDICATOR_CFLAGS) \
 	$(COVERAGE_CFLAGS) \
 	-DDATADIR="\"$(pkgdatadir)\"" \
-	-Wall -Werror \
+	-Wall -Werror -Wno-error=deprecated-declarations \
 	-DG_LOG_DOMAIN=\"indicator-application-service\"
 
 indicator_application_service_LDADD = \