Code review comment for lp:~schwuk/gwibber/notifications

Revision history for this message
Dominic Evans (oldmanuk) wrote :

Approved.

Had to update NotificationClosed handler to cope with 'reason' param on glago latest notification spec (tested on Jaunty and Intrepid) -- http://galago-project.org/specs/notification/0.9/x408.html#signal-notification-closed, but other seems good.

Will merge to lp:gwibber and lp:gwibber/1.0

review: Approve

« Back to merge proposal