Merge lp:~schwuk/gwibber/notifications into lp:gwibber/1.2

Proposed by David Murphy
Status: Merged
Merged at revision: not available
Proposed branch: lp:~schwuk/gwibber/notifications
Merge into: lp:gwibber/1.2
To merge this branch: bzr merge lp:~schwuk/gwibber/notifications
Reviewer Review Type Date Requested Status
Dominic Evans (community) Approve
Review via email: mp+3461@code.launchpad.net
To post a comment you must log in.
Revision history for this message
David Murphy (schwuk) wrote :

This branch does three things:

 1. Fixes notification bubbles so that when they expire, they are deleted from self.notification_bubbles.
 2. Displays notification bubbles *after* the display has been updated.
 3. Displays notification bubbles in chronological order (oldest first) so they are easier to read/scan.

Revision history for this message
Dominic Evans (oldmanuk) wrote :

Approved.

Had to update NotificationClosed handler to cope with 'reason' param on glago latest notification spec (tested on Jaunty and Intrepid) -- http://galago-project.org/specs/notification/0.9/x408.html#signal-notification-closed, but other seems good.

Will merge to lp:gwibber and lp:gwibber/1.0

review: Approve

Subscribers

People subscribed via source and target branches