Merge lp:~salgado/linaro-image-tools/fix-packaging-and-ensure-command into lp:linaro-image-tools/11.11
Proposed by
Guilherme Salgado
Status: | Merged |
---|---|
Merged at revision: | 242 |
Proposed branch: | lp:~salgado/linaro-image-tools/fix-packaging-and-ensure-command |
Merge into: | lp:linaro-image-tools/11.11 |
Diff against target: |
234 lines (+67/-48) 6 files modified
debian/control (+5/-0) linaro-media-create (+14/-11) linaro_media_create/ensure_command.py (+0/-13) linaro_media_create/hwpack.py (+2/-5) linaro_media_create/tests/fixtures.py (+4/-0) linaro_media_create/tests/test_media_create.py (+42/-19) |
To merge this branch: | bzr merge lp:~salgado/linaro-image-tools/fix-packaging-and-ensure-command |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Loïc Minier (community) | Approve | ||
Review via email: mp+46509@code.launchpad.net |
Description of the change
- change Depends: to add some dependencies that were required in
practice
- add a couple qemu-kvm packages to Suggests: although we should add them to
Depends: once they build successfully on Ubuntu/armel. Is this the correct
approach or should we add them to Depends: now and render l-i-t
uninstallable on armel until qemu-kvm builds there?
- change ensure_command to figure out the package which provides the given
command so that callsites don't need to specify that.
in a subsequent branch I'll change ensure_command to ask for confirmation
before installing anything
To post a comment you must log in.
Awesome, thanks
One question: why the qemu-kvm dep? I thought only qemu-kvm- extras- static was needed for qemu-arm-static?
I think you could make qemu-kvm- extras- static a Recommends (this reflects that it might not be needed in some combinations). It is a hard requirement on x86 arches right now and useless on arm right now, but it shouldn't be if linaro-image-tools was able to write any image architecture on any host. I think this is preferable to having an arch: any package just to repeat this hardcoding in the packaging.