Code review comment for lp:~salgado/linaro-image-tools/fix-packaging-and-ensure-command

On Mon, 2011-01-17 at 18:13 +0000, Loïc Minier wrote:
> Review: Approve
> Awesome, thanks
>
> One question: why the qemu-kvm dep? I thought only qemu-kvm-extras-static was needed for qemu-arm-static?

qemu-kvm is needed because we use qemu-img to generate qemu images.

>
> I think you could make qemu-kvm-extras-static a Recommends (this reflects that it might not be needed in some combinations). It is a hard requirement on x86 arches right now and useless on arm right now, but it shouldn't be if linaro-image-tools was able to write any image architecture on any host. I think this is preferable to having an arch: any package just to repeat this hardcoding in the packaging.

Fair enough, I'll do that.

> Hmm also, filesystems should be Recommends and perhaps even Suggests
> in the case of btrfs.

I've added them to Depends: because at least one of them (e2fsprogs or
btrfs-tools) will be needed. Given that, does it make sense to have
them as Recommends/Suggests or should the one used by default
(e2fsprogs) be a hard dependency and btrfs-tools a suggestion?