Code review comment for lp:~salgado/linaro-image-tools/bug-814256

Revision history for this message
Guilherme Salgado (salgado) wrote :

On Thu, 2011-07-21 at 22:27 +0000, James Westby wrote:
> Review: Approve
> Hi,
>
> I'm guessing the rest of the code doesn't rely on the device
> being unmounted, so removing the sequential unmount is ok.

There's no code running after this, so I think just changing the
docstring to state clearly that the umount won't happen until l-m-c
exits is fine.

Thanks for the review!

« Back to merge proposal