Merge lp:~salgado/linaro-image-tools/bug-814256 into lp:linaro-image-tools/11.11
Proposed by
Guilherme Salgado
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | James Westby | ||||
Approved revision: | 385 | ||||
Merged at revision: | 384 | ||||
Proposed branch: | lp:~salgado/linaro-image-tools/bug-814256 | ||||
Merge into: | lp:linaro-image-tools/11.11 | ||||
Diff against target: |
106 lines (+25/-13) 2 files modified
linaro_image_tools/media_create/rootfs.py (+18/-11) linaro_image_tools/media_create/tests/test_media_create.py (+7/-2) |
||||
To merge this branch: | bzr merge lp:~salgado/linaro-image-tools/bug-814256 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Westby (community) | Approve | ||
Review via email: mp+68751@code.launchpad.net |
Description of the change
Make sure the root partition is umounted if something goes wrong while it's
being populated.
To post a comment you must log in.
Hi,
I'm guessing the rest of the code doesn't rely on the device
being unmounted, so removing the sequential unmount is ok.
On whether it should ignore errors or not, given that Python
reports atexit errors separately and doesn't override any
exception thrown by the code I think that's fine. You will
see the original error, and be alerted to any cleanup failure.
Thanks,
James