Code review comment for lp:~salgado/launchpad/bug-452525

= Summary =

Today, if you try to reset the password of an account in the NOACCOUNT
state, the password will be changed but the account will be left
unusable.

== Proposed fix ==

Just like we do when resetting the password of a DEACTIVATED account,
activate the account (in the NOACCOUNT state) for which the password is
being reset.

The actual bug was triggered through the login service, but a test for
that would have to go into the canonical-identity-provider, whereas the
fix (as you can see) is in launchpad. What I'd like to do is land this
fix with the LP-specific test and open an extra task on bug 452525 for
canonical-identity-provider to have a similar test there. The test
there would be really trivial as it'd just have to inherit from
TestPasswordReset (added here).

== Tests ==

./bin/test -vvt test_password_reset

== Demo and Q/A ==

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/browser/tests/test_password_reset.py
  lib/devscripts/ec2test/instance.py
  lib/canonical/launchpad/browser/logintoken.py

== Pylint notices ==

lib/devscripts/ec2test/instance.py
    409: [W0703, EC2Instance.set_up_and_run] Catch "Exception"