Merge lp:~salgado/launchpad/bug-452525 into lp:launchpad
Proposed by
Guilherme Salgado
Status: | Merged |
---|---|
Approved by: | Aaron Bentley |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~salgado/launchpad/bug-452525 |
Merge into: | lp:launchpad |
Diff against target: |
84 lines 3 files modified
lib/canonical/launchpad/browser/logintoken.py (+2/-1) lib/canonical/launchpad/browser/tests/test_password_reset.py (+55/-0) lib/devscripts/ec2test/instance.py (+1/-1) |
To merge this branch: | bzr merge lp:~salgado/launchpad/bug-452525 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | code | Approve | |
Review via email: mp+13873@code.launchpad.net |
To post a comment you must log in.
= Summary =
Today, if you try to reset the password of an account in the NOACCOUNT
state, the password will be changed but the account will be left
unusable.
== Proposed fix ==
Just like we do when resetting the password of a DEACTIVATED account,
activate the account (in the NOACCOUNT state) for which the password is
being reset.
The actual bug was triggered through the login service, but a test for identity- provider, whereas the identity- provider to have a similar test there. The test
that would have to go into the canonical-
fix (as you can see) is in launchpad. What I'd like to do is land this
fix with the LP-specific test and open an extra task on bug 452525 for
canonical-
there would be really trivial as it'd just have to inherit from
TestPasswordReset (added here).
== Tests ==
./bin/test -vvt test_password_reset
== Demo and Q/A ==
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: /launchpad/ browser/ tests/test_ password_ reset.py s/ec2test/ instance. py /launchpad/ browser/ logintoken. py
lib/canonical
lib/devscript
lib/canonical
== Pylint notices ==
lib/devscripts/ ec2test/ instance. py set_up_ and_run] Catch "Exception"
409: [W0703, EC2Instance.