Merge ~sajoupa/charm-nrpe:ro-filesystems-systemd-sysusers into charm-nrpe:master

[Laurent Sesquès]

add /run/credentials/systemd-sysusers.service to ro_filesystem_excludes default value for jammy

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack)]

FAILED: Continuous integration, rev:ae502078c1ce0b1b271fa017b595912ba0da34d0
https://jenkins.canonical.com/bootstack/job/lp-charm-nrpe-ci/150/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/1352/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/1681/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-nrpe-ci/150//rebuild

review: Needs Fixing (continuous-integration)

[Erhan Sunar (esunar)]

can you also pin the flake8 in tox.ini so it can pass the tests
flake8<6.0.0 # https://github.com/PyCQA/flake8-import-order/issues/189

review: Needs Fixing

[Laurent Sesquès (sajoupa)]

> can you also pin the flake8 in tox.ini so it can pass the tests
> flake8<6.0.0 # https://github.com/PyCQA/flake8-import-order/issues/189

Shouldn't this be in a separate commit / MP ?

[Erhan Sunar (esunar)]

Can be, but because of this functional tests are not running. Can you create another MP and just make this depend on other. Or just add this to this MP

> > can you also pin the flake8 in tox.ini so it can pass the tests
> > flake8<6.0.0 # https://github.com/PyCQA/flake8-import-order/issues/189
>
> Shouldn't this be in a separate commit / MP ?

[Eric Chen (eric-chen)]

Hi Laurent,

Could you rebase your code to the lastest commit?

Gabriel pass the jenkins verification.
https://code.launchpad.net/~gabrielcocenza/charm-nrpe/+git/charm-nrpe/+merge/434197

[Eric Chen (eric-chen)]

Change the status to WIP until we get the latest jenkins verification.

Unmerged commits

ae50207... by Laurent Sesquès on 2022-11-24

add /run/credentials/systemd-sysusers.service to ro_filesystem_excludes default value for jammy

diff --git a/config.yaml b/config.yaml
index b81e3f3..3c7d90c 100644
--- a/config.yaml
+++ b/config.yaml
@@ -240,7 +240,7 @@ options:
         .
         Defaults to disabled, set the time to enable.
   ro_filesystem_excludes:
-    default: "/snap/,/sys/fs/cgroup,/run/containerd,/var/lib/docker"
+    default: "/snap/,/sys/fs/cgroup,/run/containerd,/var/lib/docker,/run/credentials/systemd-sysusers.service"
     type: string
     description: |
       Comma separated list of mount points to exclude from checks for readonly filesystem.