NRPE Charm

Code review comment for ~sajoupa/charm-nrpe:ro-filesystems-systemd-sysusers

  1. Git
  2. lp:~sajoupa/charm-nrpe
  3. ro-filesystems-systemd-sysusers
  4. Merge into master
Revision history for this message
Erhan Sunar (esunar) wrote :

Can be, but because of this functional tests are not running. Can you create another MP and just make this depend on other. Or just add this to this MP

> > can you also pin the flake8 in tox.ini so it can pass the tests
> > flake8<6.0.0 # https://github.com/PyCQA/flake8-import-order/issues/189
>
> Shouldn't this be in a separate commit / MP ?

Reply

« Back to merge proposal