Merge lp:~rvb/maas/stop-button into lp:~maas-committers/maas/trunk
Proposed by
Raphaël Badin
Status: | Merged |
---|---|
Approved by: | Raphaël Badin |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1489 |
Proposed branch: | lp:~rvb/maas/stop-button |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
113 lines (+51/-0) 2 files modified
src/maasserver/node_action.py (+15/-0) src/maasserver/tests/test_node_action.py (+36/-0) |
To merge this branch: | bzr merge lp:~rvb/maas/stop-button |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | Approve | ||
Review via email: mp+165054@code.launchpad.net |
Commit message
Add stop node button.
Description of the change
Add a "stop node" button in the UI.
Drive-by fix: refactored the tests so that each button has it's own test class. It makes it more simple to spot how many tests we have for each type of button and copy the tests over when one creates a new button (and the tests that goes with it).
To post a comment you must log in.
Good stuff. Only one very mild suggestion: it would be more specific to tell the user that the node has been asked to "shut down," rather than to "stop."
That makes it more obvious that this is a "stop" at the system level, not at the service level. I'm guessing that it might be slightly puzzling if the request "stop this node" translates to "ask the node to stop" plus something else.
Jeroen