Code review comment for lp:~rvb/maas/stop-button

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Good stuff. Only one very mild suggestion: it would be more specific to tell the user that the node has been asked to "shut down," rather than to "stop."

That makes it more obvious that this is a "stop" at the system level, not at the service level. I'm guessing that it might be slightly puzzling if the request "stop this node" translates to "ask the node to stop" plus something else.

Jeroen

review: Approve

« Back to merge proposal