Code review comment for lp:~rvb/maas/packaging.sudo-mipf

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Thanks for fixing this. In the associated code MP at https://code.launchpad.net/~rvb/maas/sudo-mipf/+merge/132873 I raised one question: the sudoers change says /usr/sbin/maas-import-pxe-files, whereas the actual invocation just calls maas-import-pxe-files and relies on the system path. Just out of precaution, can you think of any situations where that might be a problem?

review: Approve

« Back to merge proposal