Merge lp:~rvb/maas/packaging.sudo-mipf into lp:~maas-maintainers/maas/packaging

Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: 143
Merged at revision: 143
Proposed branch: lp:~rvb/maas/packaging.sudo-mipf
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 20 lines (+3/-0)
2 files modified
debian/changelog (+2/-0)
debian/extras/99-maas-sudoers (+1/-0)
To merge this branch: bzr merge lp:~rvb/maas/packaging.sudo-mipf
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+132874@code.launchpad.net

Commit message

Add sudo rule so that the script maas-import-pxe-files can be called by the user 'maas'.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Thanks for fixing this. In the associated code MP at https://code.launchpad.net/~rvb/maas/sudo-mipf/+merge/132873 I raised one question: the sudoers change says /usr/sbin/maas-import-pxe-files, whereas the actual invocation just calls maas-import-pxe-files and relies on the system path. Just out of precaution, can you think of any situations where that might be a problem?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-10-29 14:18:01 +0000
3+++ debian/changelog 2012-11-05 11:58:42 +0000
4@@ -5,6 +5,8 @@
5 file /etc/bind/maas/named.conf.rndc.maas. (LP: #1066935)
6 * debian/control: Remove the dependency of maas-cluster-controller
7 on rabbitmq-server. (LP: #1072744)
8+ * debian/extras/99-maas-sudoers: Add sudo rule for script
9+ /usr/sbin/maas-import-pxe-files.
10
11 [ Julian Edwards ]
12 * debian/maas-region-controller.install: Remove installation of maas-gc; it
13
14=== modified file 'debian/extras/99-maas-sudoers'
15--- debian/extras/99-maas-sudoers 2012-09-25 23:18:02 +0000
16+++ debian/extras/99-maas-sudoers 2012-11-05 11:58:42 +0000
17@@ -1,2 +1,3 @@
18 maas ALL= NOPASSWD: /usr/sbin/service maas-dhcp-server restart
19 maas ALL= NOPASSWD: /usr/sbin/maas-provision
20+maas ALL= NOPASSWD: /usr/sbin/maas-import-pxe-files

Subscribers

People subscribed via source and target branches