> Looks sensible. In src/maasserver/views/settings_clusters.py, is there any
> need for get_form_kwargs() to check whether 'instance' might already be set?
Well, not really, this is a method on ClusterInterfaceCreate(). That view is there to handle the *creation* of an interface so it's guaranteed that no instance will be there already. I'll put an assertion.
> Looks sensible. In src/maasserver/ views/settings_ clusters. py, is there any
> need for get_form_kwargs() to check whether 'instance' might already be set?
Well, not really, this is a method on ClusterInterfac eCreate( ). That view is there to handle the *creation* of an interface so it's guaranteed that no instance will be there already. I'll put an assertion.
Thanks for the review!