Code review comment for lp:~rvb/maas/add-version-switcher-1.5

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On 08/04/14 03:37, Raphaël Badin wrote:
>
>>> I think it would look better if you could put the switcher at the top
>>> somewhere so that it's more prominent. Also, its title should be
>>> "Documentation for MAAS version:"
>>
>> Okay, I'll do that.
>
> I moved the widget at the top… but I left the title as is since "Documentation for MAAS version:" really doesn't fit (it takes two lines and it's ugly).
>
>

Please, the title needs to change, make the text smaller if you have to.

"Version" doesn't mean much on its own like that. "Version what?" was
my first thought, especially when I clicked on it it was initially empty
and only loaded later. Maybe its default values should say "loading...".

« Back to merge proposal