Merge lp:~rvb/maas/add-version-switcher-1.5 into lp:maas/1.5
Status: | Merged |
---|---|
Approved by: | Raphaël Badin |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2229 |
Proposed branch: | lp:~rvb/maas/add-version-switcher-1.5 |
Merge into: | lp:maas/1.5 |
Diff against target: |
85 lines (+41/-0) 4 files modified
Makefile (+3/-0) docs/_templates/maas/layout.html (+1/-0) docs/_templates/maas/relations.html (+12/-0) docs/conf.py (+25/-0) |
To merge this branch: | bzr merge lp:~rvb/maas/add-version-switcher-1.5 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Julian Edwards (community) | Approve | ||
Review via email: mp+214422@code.launchpad.net |
Commit message
Add the version switcher widget. Add the new `doc-with-versions` make target to generate a version of the documentation that includes the version switcher widget.
Description of the change
This works in conjunction with https:/
The change to the 1.5 branch should be a one-off. No further modification should be required, even when publishing a new version of the documentation.
If 'add_version_
See the result at http://
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
review: approve
Nice work Raphers! Just a question and a suggestion:
On 07/04/14 02:32, Raphaël Badin wrote:
> Raphaël Badin has proposed merging
> lp:~rvb/maas/add-version-switcher-1.5 into lp:maas/1.5.
>
> Commit message: Add the version switcher widget. Add the new
> `doc-with-versions` make target to generate a version of the
> documentation that includes the version switcher widget.
Is there a reason to make this conditional?
> This works in conjunction with /code.launchpad .net/~rvb/ maas/multiple- versions- doc-1.6/ +merge/ 214424. switcher' is set to True, the code in /maas/relations .html dynamically fetches the 162.213. 35.95:8000/ docs
> https:/
>
> The change to the 1.5 branch should be a one-off. No further
> modification should be required, even when publishing a new version
> of the documentation.
>
> If 'add_version_
> docs/_templates
> Javascript file used to generate the version switcher widget from
> the trunk documentation.
>
> See the result at http://
>
I think it would look better if you could put the switcher at the top
somewhere so that it's more prominent. Also, its title should be
"Documentation for MAAS version:"
-----BEGIN PGP SIGNATURE----- www.enigmail. net/
CVUAACgkQWhGlTF 8G/Hc9CQCdESXPX 3wM1L41K9GXftUY 5Xiw RClocmJarUHRTm9 P8
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://
iEYEARECAAYFAlN
0asAn1po0JklTow
=yGGO
-----END PGP SIGNATURE-----