Code review comment for lp:~rsalveti/indicator-network/change-signal-strength-thresholds-android

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

This should really be handled on ofono side as it's specific to a single modem tech.

Ofono reports the signal strength through org.ofono.NetworkRegistration Strength property:

Service org.ofono
Interface org.ofono.NetworkRegistration
Object path [variable prefix]/{modem0,modem1,...}

Properties byte Strength [readonly, optional]

                        Contains the current signal strength as a percentage
                        between 0-100 percent.

Also the latter part of this patch is modifying the wifi icons.

review: Disapprove

« Back to merge proposal