Merge lp:~rsalveti/indicator-network/change-signal-strength-thresholds-android into lp:indicator-network/14.10

[Ricardo Salveti]

Changing signal strength thresholds to follow values use by Android (LP: #1329945)

Changing signal strength thresholds to follow values use by Android

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:346
http://jenkins.qa.ubuntu.com/job/indicator-network-ci/141/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-utopic-amd64-ci/15
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-network-utopic-armhf-ci/15/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-network-ci/141/rebuild

review: Needs Fixing (continuous-integration)

[Antti Kaijanmäki (kaijanmaki)]

This should really be handled on ofono side as it's specific to a single modem tech.

Ofono reports the signal strength through org.ofono.NetworkRegistration Strength property:

Service org.ofono
Interface org.ofono.NetworkRegistration
Object path [variable prefix]/{modem0,modem1,...}

Properties byte Strength [readonly, optional]

                        Contains the current signal strength as a percentage
                        between 0-100 percent.

Also the latter part of this patch is modifying the wifi icons.

review: Disapprove

[lp:~rsalveti/indicator-network/change-signal-strength-thresholds-android]

347. By Ricardo Salveti on 2014-06-17

Not changing the wifi signal strength

[Ricardo Salveti (rsalveti)]

This shouldn't be handled by ofono, and the tech specifics should also be handled by the client side, not ofono.

Percentage is not ideal, and not linear, but it was what was used by ofono initially (see https://lists.ofono.org/pipermail/ofono/2011-January/007827.html).

We could just change it to report asu values (what we get from the modem), but then the same logic applied bellow would need be used, just with different values.

The only think ofono does is converting ASU (as defined by TS 27.007 8.5) to percentage (x-100/31)

[lp:~rsalveti/indicator-network/change-signal-strength-thresholds-android]

348. By Ricardo Salveti on 2014-06-17

Removing comment added previously in the wifi code block

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:348
http://jenkins.qa.ubuntu.com/job/indicator-network-ci/142/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-utopic-amd64-ci/16
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-network-utopic-armhf-ci/16/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-network-ci/142/rebuild

review: Needs Fixing (continuous-integration)

[Antti Kaijanmäki (kaijanmaki)]

Let's have comment from awe before proceeding.

review: Needs Information

[Antti Kaijanmäki (kaijanmaki)]

OK, let's have this in the indicator then.

review: Approve

=== modified file 'network/root-state.cpp'
--- network/root-state.cpp	2014-05-21 17:56:25 +0000
+++ network/root-state.cpp	2014-06-17 12:27:22 +0000
@@ -174,13 +174,14 @@
         }
 
         auto strength = modem->strength().get();
-        if (strength >= 80)
+        /* Using same values as used by Android, not linear (LP: #1329945)*/
+        if (strength >= 39)
             m_cellularIcons[modem] = "gsm-3g-full";
-        else if (strength >= 60)
+        else if (strength >= 26)
             m_cellularIcons[modem] = "gsm-3g-high";
-        else if (strength >= 40)
+        else if (strength >= 16)
             m_cellularIcons[modem] = "gsm-3g-medium";
-        else if (strength >= 20)
+        else if (strength >= 6)
             m_cellularIcons[modem] = "gsm-3g-low";
         else
             m_cellularIcons[modem] = "gsm-3g-none";