Merge lp:~rsalveti/goget-ubuntu-touch/touch_serial_adb_push_vivid into lp:goget-ubuntu-touch/vivid

Proposed by Ricardo Salveti
Status: Needs review
Proposed branch: lp:~rsalveti/goget-ubuntu-touch/touch_serial_adb_push_vivid
Merge into: lp:goget-ubuntu-touch/vivid
Diff against target: 33 lines (+11/-13)
1 file modified
ubuntu-device-flash/touch.go (+11/-13)
To merge this branch: bzr merge lp:~rsalveti/goget-ubuntu-touch/touch_serial_adb_push_vivid
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+257178@code.launchpad.net

This proposal supersedes a proposal from 2015-04-22.

Commit message

touch: don't use parallel adb push as that is not so reliable with arale

Description of the change

touch: don't use parallel adb push as that is not so reliable with arale

To post a comment you must log in.

Unmerged revisions

143. By Ricardo Salveti

touch: don't use parallel adb push as that is not so reliable with arale

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntu-device-flash/touch.go'
--- ubuntu-device-flash/touch.go 2015-02-10 05:51:08 +0000
+++ ubuntu-device-flash/touch.go 2015-04-22 21:04:07 +0000
@@ -306,19 +306,17 @@
306 }306 }
307 for {307 for {
308 file := <-files308 file := <-files
309 go func() {309 log.Printf("Start pushing %s to device", file.FilePath)
310 log.Printf("Start pushing %s to device", file.FilePath)310 err := adb.Push(file.FilePath, "/cache/recovery/")
311 err := adb.Push(file.FilePath, "/cache/recovery/")311 if err != nil {
312 if err != nil {312 log.Fatal(err)
313 log.Fatal(err)313 }
314 }314 err = adb.Push(file.SigPath, "/cache/recovery/")
315 err = adb.Push(file.SigPath, "/cache/recovery/")315 if err != nil {
316 if err != nil {316 log.Fatal(err)
317 log.Fatal(err)317 }
318 }318 log.Printf("Done pushing %s to device", file.FilePath)
319 log.Printf("Done pushing %s to device", file.FilePath)319 done <- true
320 done <- true
321 }()
322 }320 }
323}321}
324322

Subscribers

People subscribed via source and target branches